Skip to content

[src] Fix a few issues in some availability attributes.#17003

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:src-tweak-availability
Dec 12, 2022
Merged

[src] Fix a few issues in some availability attributes.#17003
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:src-tweak-availability

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

@rolfbjarne rolfbjarne commented Dec 7, 2022

  • There's no such thing as Mac Catalyst 8.0. This is probably copied from iOS 8.0,
    which is supported in all versions of Mac Catalyst, so just remove the version
    for the corresponding SupportedOSPlatform attributes.
  • Remove the version in SupportedOSPlatform attributes when the version is equal
    to or lower than the min OS version we support for the given platform.
  • Remove UnsupportedOSPlatform attributes when there's an identical ObsoletedOSPlatform
    attribute.
  • Remove UnsupportedOSPlatform attributes when it's a blatent lie, because the
    API is available (in Security/Certificate.cs).
  • There's no such thing as Mac Catalyst 10.13. It looks like this was a typo, meant
    to be Mac Catalyst 13.0.

@rolfbjarne
[src] Fix a few issues in some availability attributes.
3cd06b3 
* There's no such thing as Mac Catalyst 8.0. This is probably copied from iOS 8.0,
  which is supported in all versions of Mac Catalyst, so just remove the version
  for the corresponding SupportedOSPlatform attributes.
* Remove the version in SupportedOSPlatform attributes when the version is equal
  to or lower than the min OS version we support for the given platform.
* Remove UnsupportedOSPlatform attributes when there's an identical ObsoletedOSPlatform
  attribute.
* Remove UnsupportedOSPlatform attributes when it's a blatent lie, because the
  API is available (in Security/Certificate.cs).
* There's no such thing as Mac Catalyst 10.13. It looks like this was a typo, meant
  to be Mac Catalyst 13.0.
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Dec 7, 2022

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1033.Monterey'
Hash: 3cd06b30c17128d78df91a547908576fe00c3cff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Dec 7, 2022

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 3cd06b30c17128d78df91a547908576fe00c3cff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Dec 7, 2022

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3cd06b30c17128d78df91a547908576fe00c3cff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Dec 8, 2022

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3cd06b30c17128d78df91a547908576fe00c3cff [PR build]

@rolfbjarne rolfbjarne merged commit 7d6e45f into dotnet:main Dec 12, 2022
@rolfbjarne rolfbjarne deleted the src-tweak-availability branch December 12, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto