[msbuild] Validate OutputType property by ylatuya · Pull Request #16871 · dotnet/macios

ylatuya · 2022-11-22T16:47:25Z

➜  test dotnet build  -bl:msbuild.binlog
MSBuild version 17.3.2+561848881 for .NET
/usr/local/share/dotnet/sdk/6.0.403/MSBuild.dll -bl:msbuild.binlog -consoleloggerparameters:Summary -distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,/usr/local/share/dotnet/sdk/6.0.403/dotnet.dll*Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,/usr/local/share/dotnet/sdk/6.0.403/dotnet.dll -maxcpucount -restore -verbosity:m ./test.csproj
  Determining projects to restore...
  All projects are up-to-date for restore.
/usr/local/share/dotnet/packs/Microsoft.macOS.Sdk/12.3.471/targets/Xamarin.Shared.Sdk.targets(284,3): error : WinExe is not a valid output type for macOS [/Users/andoni/Downloads/test/test.csproj]

Build FAILED.

/usr/local/share/dotnet/packs/Microsoft.macOS.Sdk/12.3.471/targets/Xamarin.Shared.Sdk.targets(284,3): error : WinExe is not a valid output type for macOS [/Users/andoni/Downloads/test/test.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:01.14

rolfbjarne · 2022-11-29T08:58:24Z

/azp run

azure-pipelines · 2022-11-29T08:58:49Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2022-11-29T09:43:35Z

/azp run

azure-pipelines · 2022-11-29T09:43:58Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2022-11-29T11:29:52Z

+	<BuildDependsOn>
+		_VerifyValidOutputType;
+		$(BuildDependsOn);
+	</BuildDependsOn>


This must be inside a <PropertyGroup>.

Arggg... that's a copy paste issue from the installed file to the repo one.

rolfbjarne · 2022-11-29T13:10:22Z

/azp run

azure-pipelines · 2022-11-29T13:10:50Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2022-12-21T07:44:25Z

/azp run

azure-pipelines · 2022-12-21T07:44:50Z

Azure Pipelines successfully started running 1 pipeline(s).

ylatuya · 2022-12-21T10:50:27Z

I have written a new test for it.

Fixes dotnet#16865

github-actions · 2022-12-21T10:58:46Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne · 2022-12-21T12:07:27Z

/azp ru

rolfbjarne · 2022-12-21T12:07:32Z

/azp run

azure-pipelines · 2022-12-21T12:07:32Z

Command 'ru' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

azure-pipelines · 2022-12-21T12:07:58Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2022-12-21T17:12:23Z

/azp run

azure-pipelines · 2022-12-21T17:12:46Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-12-21T18:49:58Z

📚 [PR Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMBOT-1168.Monterey'
Hash: 20749c2b6557c690ec0153674902e57537288469 [PR build]

vs-mobiletools-engineering-service2 · 2022-12-21T18:52:09Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 20749c2b6557c690ec0153674902e57537288469 [PR build]

vs-mobiletools-engineering-service2 · 2022-12-21T18:54:46Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 20749c2b6557c690ec0153674902e57537288469 [PR build]

vs-mobiletools-engineering-service2 · 2022-12-21T23:45:03Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 20749c2b6557c690ec0153674902e57537288469 [PR build]

rolfbjarne · 2022-12-22T06:36:19Z

Thanks for the fix and the test!

ylatuya force-pushed the issue-16865 branch from cdbbd7d to b4a1979 Compare November 22, 2022 16:49

rolfbjarne requested changes Nov 22, 2022

View reviewed changes

Comment thread dotnet/targets/Xamarin.Shared.Sdk.targets Outdated

Comment thread dotnet/targets/Xamarin.Shared.Sdk.targets Outdated

ylatuya force-pushed the issue-16865 branch 3 times, most recently from 2c50153 to b6a81db Compare November 24, 2022 10:50

ylatuya requested a review from rolfbjarne November 29, 2022 08:34

This comment has been minimized.

Sign in to view

rolfbjarne reviewed Nov 29, 2022

View reviewed changes

ylatuya force-pushed the issue-16865 branch from 65484af to 40e6920 Compare November 29, 2022 12:59

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Dec 21, 2022

View reviewed changes

rolfbjarne added the community Community contribution ❤ label Dec 21, 2022

This comment has been minimized.

Sign in to view

ylatuya force-pushed the issue-16865 branch from a27f592 to 258c7f7 Compare December 21, 2022 10:51

[msbuild] Validate OutputType property

0c545d5

Fixes dotnet#16865

ylatuya force-pushed the issue-16865 branch from 258c7f7 to 0c545d5 Compare December 21, 2022 10:54

Auto-format source code

044b9d9

This comment has been minimized.

Sign in to view

Merge branch 'main' into issue-16865

20749c2

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Dec 22, 2022

View reviewed changes

rolfbjarne merged commit efad190 into dotnet:main Dec 22, 2022

Conversation

ylatuya commented Nov 22, 2022

Uh oh!

Uh oh!

Uh oh!

rolfbjarne commented Nov 29, 2022

Uh oh!

azure-pipelines Bot commented Nov 29, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Nov 29, 2022

Uh oh!

azure-pipelines Bot commented Nov 29, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

ylatuya Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

rolfbjarne commented Nov 29, 2022

Uh oh!

azure-pipelines Bot commented Nov 29, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Dec 21, 2022

Uh oh!

azure-pipelines Bot commented Dec 21, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ylatuya commented Dec 21, 2022

Uh oh!

github-actions Bot commented Dec 21, 2022

⚠️ Your code has been reformatted. ⚠️

Uh oh!

rolfbjarne commented Dec 21, 2022

Uh oh!

rolfbjarne commented Dec 21, 2022

Uh oh!

azure-pipelines Bot commented Dec 21, 2022

Uh oh!

azure-pipelines Bot commented Dec 21, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Dec 21, 2022

Uh oh!

azure-pipelines Bot commented Dec 21, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 21, 2022

📚 [PR Build] Artifacts 📚

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 21, 2022

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 21, 2022

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 21, 2022

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

rolfbjarne commented Dec 22, 2022

Uh oh!