[NearbyInteraction] Bump to support Xcode 14.1 by mandel-macaque · Pull Request #16338 · dotnet/macios

mandel-macaque · 2022-10-13T19:44:22Z

No description provided.

dalexsoto · 2022-10-14T01:54:53Z

src/NearbyInteraction/NICompat.cs

+#if WATCH
+	public partial class NISession {
+
+		public virtual void SetARSession (ARSession session) => throw new InvalidOperationException (Constants.ApiRemovedGeneral);


I think you need the platform supported attributes probably Obsolete?

True, I forgot the obsolete. Good catch

Nope, this is only for watch. Watch is not present on Net, so we do not need to add anything more than the Obsolete for legacy.

src/NearbyInteraction/NICompat.cs

vs-mobiletools-engineering-service2 · 2022-10-14T18:33:00Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
watchOS: vsdrops gist (No breaking changes)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

vs-mobiletools-engineering-service2 · 2022-10-14T18:39:14Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
watchOS: vsdrops gist (No breaking changes)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

vs-mobiletools-engineering-service2 · 2022-10-14T18:42:10Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

vs-mobiletools-engineering-service2 · 2022-10-14T18:46:59Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

vs-mobiletools-engineering-service2 · 2022-10-14T18:49:38Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1164.Monterey'
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

vs-mobiletools-engineering-service2 · 2022-10-14T18:51:43Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1169.Monterey'
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

vs-mobiletools-engineering-service2 · 2022-10-14T21:36:51Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 9 tests failed, 219 tests passed.

Failures

❌ bcl tests

3 tests failed, 66 tests passed.

Details

[NUnit] Mono BCL tests group 2/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
[xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
[xUnit] Mono SystemXunit/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ introspection tests

2 tests failed, 11 tests passed.

Details

introspection/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

2 tests failed, 63 tests passed.

Details

dont link/iOS Unified 64-bits - simulator/Release [dotnet]: LaunchTimedOut
link sdk/iOS Unified 64-bits - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests

2 tests failed, 21 tests passed.

Details

monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: LaunchTimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: LaunchTimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2022-10-14T22:28:20Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

2 tests crashed, 8 tests failed, 154 tests passed.

Failures

❌ bcl tests

2 tests failed, 67 tests passed.

Details

mscorlib Part 2/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
mscorlib Part 3/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ interdependent_binding_projects tests

1 tests failed, 6 tests passed.

Details

interdependent-binding-projects/tvOS - simulator/Debug [dotnet]: LaunchTimedOut

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.

Details

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

🔥 Failed catastrophically on VSTS: simulator tests - linker (no summary found).

Html Report (VSDrops) Download

❌ mac_binding_project tests

🔥 Failed catastrophically on VSTS: simulator tests - mac_binding_project (no summary found).

Html Report (VSDrops) Download

❌ mononative tests

1 tests failed, 11 tests passed.

Details

mono-native-compat/iOS Unified Today Extension 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests

2 tests failed, 21 tests passed.

Details

monotouch-test/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): TimedOut

Html Report (VSDrops) Download

❌ mtouch tests

1 tests failed, 0 tests passed.

Details

MTouch tests/NUnit: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

[NearbyInteraction] Bump to support Xcode 14.1

e5ea592

mandel-macaque added the notes-mention Deserves a mention in release notes label Oct 13, 2022

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Oct 13, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto requested changes Oct 14, 2022

View reviewed changes

Add missing attrs.

96d58f2

mandel-macaque commented Oct 14, 2022

View reviewed changes

src/NearbyInteraction/NICompat.cs Outdated Show resolved Hide resolved

tab tab

aedd76d

mandel-macaque commented Oct 14, 2022

View reviewed changes

src/NearbyInteraction/NICompat.cs Outdated Show resolved Hide resolved

dalexsoto approved these changes Oct 14, 2022

View reviewed changes

tab tat

fae0e52

mandel-macaque merged commit 093b5d2 into dotnet:xcode14.1 Oct 17, 2022

mandel-macaque deleted the nearbyinteraction-xcode14.1-b3 branch October 17, 2022 15:46

Conversation

mandel-macaque commented Oct 13, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

dalexsoto Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

❌ introspection tests

❌ linker tests

❌ monotouch tests

Successes

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

❌ interdependent_binding_projects tests

❌ introspection tests

❌ linker tests

❌ mac_binding_project tests

❌ mononative tests

❌ monotouch tests

❌ mtouch tests

Successes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants