[HomeKit] Added support to Xcode 14.1 b1-b3#16069
[HomeKit] Added support to Xcode 14.1 b1-b3#16069mandel-macaque merged 11 commits intodotnet:xcode14.1from
Conversation
SotoiGhost
commented
Sep 22, 2022
- Matter properties are still missing
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Matter properties are still missing
f06afb7 to
035f826
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| [iOS (15,2), Watch (8,3), TV (15,2), MacCatalyst (15,2)] | ||
| [BaseType (typeof (NSObject))] | ||
| [DisableDefaultCtor] | ||
| interface HMMatterHome : NSCopying, NSSecureCoding |
There was a problem hiding this comment.
Was it intentional to remove these types?
There was a problem hiding this comment.
I don't think so, since it won't compile without them.
There was a problem hiding this comment.
Oh nevermind! I see that's what those added classes are there for!
chamons
left a comment
There was a problem hiding this comment.
Approved assuming apidiff comes back clean now.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rolfbjarne
left a comment
There was a problem hiding this comment.
Looks mostly good, but the api diff is still red on tvOS, Mac Catalyst and watchOS:
Removed Type HomeKit.HMFetchRoomHandler
Removed Type HomeKit.HMMatterHome
Removed Type HomeKit.HMMatterRequestHandler
Removed Type HomeKit.HMMatterRoom
Removed Type HomeKit.HMMatterTopology
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 11 tests failed, 217 tests passed. Failures❌ bcl testsDetails
Html Report (VSDrops) Download ❌ framework testsDetails
Html Report (VSDrops) Download ❌ interdependent_binding_projects testsDetails
Html Report (VSDrops) Download ❌ introspection testsDetails
Html Report (VSDrops) Download ❌ linker testsDetails
Html Report (VSDrops) Download ❌ monotouch testsDetails
Html Report (VSDrops) Download ❌ xcframework testsDetails
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 8 tests failed, 220 tests passed. Failures❌ bcl tests [attempt 2]Details
Html Report (VSDrops) Download ❌ framework tests [attempt 2]Details
Html Report (VSDrops) Download ❌ introspection tests [attempt 2]Details
Html Report (VSDrops) Download ❌ linker tests [attempt 2]Details
Html Report (VSDrops) Download ❌ monotouch tests [attempt 2]Details
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 7 tests failed, 221 tests passed. Failures❌ bcl tests [attempt 3]Details
Html Report (VSDrops) Download ❌ introspection tests [attempt 3]Details
Html Report (VSDrops) Download ❌ linker tests [attempt 3]Details
Html Report (VSDrops) Download ❌ monotouch tests [attempt 3]Details
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |