Skip to content

[UIkit] Add generic callbacks for UIGestureRecognizer#15846

Merged
mandel-macaque merged 3 commits intodotnet:mainfrom
haritha-mohan:improve-code-generics
Sep 2, 2022
Merged

[UIkit] Add generic callbacks for UIGestureRecognizer#15846
mandel-macaque merged 3 commits intodotnet:mainfrom
haritha-mohan:improve-code-generics

Conversation

@haritha-mohan
Copy link
Contributor

Simplifies code and makes bug easier to fix.

@haritha-mohan haritha-mohan added the not-notes-worthy Ignore for release notes label Sep 1, 2022
@mandel-macaque mandel-macaque changed the title Add generic callbacks [UIkit] Add generic callbacks for UIGestureRecognizer Sep 1, 2022
Copy link
Contributor

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

Copy link
Contributor

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change in visibility.

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the change but it may not work, let me think a little
My bad! I was thinking of something else

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, less code is always good!

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
@mandel-macaque mandel-macaque merged commit 0d55330 into dotnet:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants