[GameController] Update bindings for Xcode 14 beta 1-5 by tj-devel709 · Pull Request #15692 · dotnet/macios

tj-devel709 · 2022-08-17T21:41:16Z

No description provided.

…oller-Beta4

tj-devel709 · 2022-08-17T21:45:22Z

src/gamecontroller.cs

+	[DisableDefaultCtor]
+	interface GCPhysicalInputElementCollection<KeyIdentifierType, ElementIdentifierType> // : INSFastEnumeration // # no generator support for FastEnumeration - https://bugzilla.xamarin.com/show_bug.cgi?id=4391
+		where KeyIdentifierType : IGCPhysicalInputElementName /* NSString */ // there's currently not an conversion from GCPhysicalInputElementName, GCButtonElementName, and GCDirectionPadElementName to NSString
+		where ElementIdentifierType : IGCPhysicalInputElement


I'm having trouble using this interface with all the different protocols that try to use different protocols for the 'KeyIdentifierType': GCPhysicalInputElementName, GCButtonElementName, and GCDirectionPadElementName

src/gamecontroller.cs

mandel-macaque · 2022-08-18T12:23:11Z

src/gamecontroller.cs

+
+		[Export ("elementForAlias:")]
+		[return: NullAllowed]
+		IGCPhysicalInputElement GetElement (string alias);


Weird, since you have a generic class that is returning the ElementIdentifierType.

…oller-Beta4

rolfbjarne · 2022-08-24T10:32:32Z

src/gamecontroller.cs

+		float MaximumDegreesOfRotation { get; }
+	}
+
+	interface IGCAxisElementName {}


Whoever implemented this at Apple found a very complicated solution to something that looks quite simple.

I had a look at the headers, and it seems that these protocols is an attempt to group different NSString values together - basically creating an NSString-based enum of sorts 🤯

In any case, what I think we should do:

Don't bind any protocols that are defined with objc_non_runtime_protocol:

__attribute__((objc_non_runtime_protocol)) NS_REFINED_FOR_SWIFT @protocol GCPhysicalInputElementName @end __attribute__((objc_non_runtime_protocol)) NS_REFINED_FOR_SWIFT @protocol GCButtonElementName <GCPhysicalInputElementName> @end __attribute__((objc_non_runtime_protocol)) NS_REFINED_FOR_SWIFT @protocol GCAxisElementName <GCPhysicalInputElementName> @end __attribute__((objc_non_runtime_protocol)) NS_REFINED_FOR_SWIFT @protocol GCSwitchElementName <GCPhysicalInputElementName> @end __attribute__((objc_non_runtime_protocol)) NS_REFINED_FOR_SWIFT @protocol GCDirectionPadElementName <GCPhysicalInputElementName> @end

For each of these protocols, create a strong enum, and add the fields declared with each protocol to the corresponding enum.

For example:

GAMECONTROLLER_EXTERN GCInputButtonName GCInputButtonA NS_REFINED_FOR_SWIFT API_AVAILABLE(macos(11.0), ios(14.0), tvos(14.0)); GAMECONTROLLER_EXTERN GCInputButtonName GCInputButtonB NS_REFINED_FOR_SWIFT API_AVAILABLE(macos(11.0), ios(14.0), tvos(14.0)); GAMECONTROLLER_EXTERN GCInputButtonName GCInputButtonX NS_REFINED_FOR_SWIFT API_AVAILABLE(macos(11.0), ios(14.0), tvos(14.0)); GAMECONTROLLER_EXTERN GCInputButtonName GCInputButtonY NS_REFINED_FOR_SWIFT API_AVAILABLE(macos(11.0), ios(14.0), tvos(14.0));

would become:

enum GCInputButtonName { [Field ("GCInputButtonA")] NSString A { get; } [Field ("GCInputButtonB")] NSString B { get; } [Field ("GCInputButtonX")] NSString X { get; } [Field ("GCInputButtonY")] NSString Y { get; } ... }

@dalexsoto / @chamons what do you think?

The simpler solution is of course to just not bind these protocols for now, and decide later.

I have to agree with @rolfbjarne this is way cleaner! the only thing is that it seems to be already done here as Fields

https://github.com/xamarin/xamarin-macios/pull/15692/files#diff-356008148e576743798c6d7e9adb15c283fdfe15e03fcae2edbe590828ccf533R1100-R1126

So probably this is not even needed? Also creating a test case may be the only way to figure out if the API is right. Maybe we can just leave them out, those protocols for now.

@dalexsoto @rolfbjarne
I have removed the protocols that have the 'objc_non_runtime_protocol' attribute!

…SWIFT protocols

…oller-Beta4

…code14-GameController-Beta4

tj-devel709 · 2022-08-30T14:25:15Z

/azp run

tj-devel709 · 2022-08-30T14:25:38Z

rekicking due to failing msbuild integration tests

azure-pipelines · 2022-08-30T14:25:56Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-08-30T16:27:38Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: d15c6ed73b8d44a9abe73f3e0da080ed1d349489 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-30T16:34:35Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d15c6ed73b8d44a9abe73f3e0da080ed1d349489 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-30T16:37:05Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1168.Monterey'
Hash: d15c6ed73b8d44a9abe73f3e0da080ed1d349489 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-30T16:44:21Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection
monotouch-test

Pipeline on Agent
Hash: d15c6ed73b8d44a9abe73f3e0da080ed1d349489 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-30T19:00:55Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 227 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.

Details

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

TJ Lambert added 4 commits August 5, 2022 11:40

start Xcode14 beta 4 GameController Changes

ac690a4

comment out parts to later ignore

09c78d9

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-GameContr…

0d2d4c5

…oller-Beta4

Xcode14 GameController Changes B5

4236743

tj-devel709 added the notes-mention Deserves a mention in release notes label Aug 17, 2022

tj-devel709 added this to the xcode14 milestone Aug 17, 2022

TJ Lambert added 2 commits August 17, 2022 16:43

small changes and formatting

5660361

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-GameContr…

0df4ccd

…oller-Beta4

tj-devel709 commented Aug 17, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque reviewed Aug 18, 2022

View reviewed changes

TJ Lambert added 2 commits August 18, 2022 13:28

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-GameContr…

2d99fbe

…oller-Beta4

use Sealed

3b3aace

This comment has been minimized.

Sign in to view

TJ Lambert and others added 4 commits August 22, 2022 15:17

Add generics issue to ignore

da65d32

use a static on the notification

d968f1d

few additional changes

7ddb0a5

Merge branch 'xcode14' into Xcode14-GameController-Beta4

16ee661

tj-devel709 marked this pull request as ready for review August 23, 2022 18:32

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Aug 24, 2022

View reviewed changes

TJ Lambert added 4 commits August 29, 2022 00:32

remove the __attribute__((objc_non_runtime_protocol)) NS_REFINED_FOR_…

ecd6bc8

…SWIFT protocols

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-GameContr…

8c505b4

…oller-Beta4

add those removed protocols to ignore files

02255e1

Merge remote-tracking branch 'TJ/Xcode14-GameController-Beta4' into X…

d15c6ed

…code14-GameController-Beta4

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Aug 30, 2022

View reviewed changes

mandel-macaque approved these changes Aug 30, 2022

View reviewed changes

dalexsoto approved these changes Aug 31, 2022

View reviewed changes

tj-devel709 merged commit 6b5364f into dotnet:xcode14 Aug 31, 2022

Conversation

tj-devel709 commented Aug 17, 2022

Uh oh!

tj-devel709 Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

mandel-macaque Aug 18, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

dalexsoto Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

tj-devel709 Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented Aug 30, 2022

Uh oh!

tj-devel709 commented Aug 30, 2022

Uh oh!

azure-pipelines bot commented Aug 30, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 30, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 30, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 30, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 30, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 30, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ introspection tests

Successes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tj-devel709 Aug 17, 2022 •

edited

Loading