[WatchKit] Add support for Xcode 14 beta 1,2 & 3 by mandel-macaque · Pull Request #15535 · dotnet/macios

mandel-macaque · 2022-07-18T05:46:20Z

No description provided.

chamons · 2022-07-18T15:08:45Z

src/watchkit.cs

+		bool IsApplicationRunningInDock { get; }
+
+		[Export ("autorotating")]
+		bool Autorotating { [Bind ("isAutorotating")] get; set; }


I'm fine with this, we tend to drop the Is prefix, but not sure if Autorotatedis the best name. Though I can't think of anything better beyond adding Is, and then we're Inconsistent.

I'm with you, I think in this case it reads better with an is. So lets do it, we will be like French, more exceptions that rules ;)

src/watchkit.cs

tj-devel709

Few name changes suggestions!

src/watchkit.cs

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2022-07-18T22:35:39Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 2a0a1887faa74e15c0068f1d86b10d57e86cf1bb [PR build]

vs-mobiletools-engineering-service2 · 2022-07-18T22:36:25Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1180.Monterey'
Hash: 2a0a1887faa74e15c0068f1d86b10d57e86cf1bb [PR build]

vs-mobiletools-engineering-service2 · 2022-07-18T22:45:59Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: 2a0a1887faa74e15c0068f1d86b10d57e86cf1bb [PR build]

vs-mobiletools-engineering-service2 · 2022-07-18T22:53:55Z

❗ API diff for current PR / commit (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2a0a1887faa74e15c0068f1d86b10d57e86cf1bb [PR build]

vs-mobiletools-engineering-service2 · 2022-07-19T02:54:30Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 227 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.

Details

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

[WatchKit] Add support for Xcode 14 beta 1,2 & 3

0deaf8e

mandel-macaque added the notes-mention Deserves a mention in release notes label Jul 18, 2022

mandel-macaque added this to the xcode14 milestone Jul 18, 2022

mandel-macaque requested a review from rolfbjarne as a code owner July 18, 2022 05:46

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jul 18, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

chamons approved these changes Jul 18, 2022

View reviewed changes

mandel-macaque commented Jul 18, 2022

View reviewed changes

src/watchkit.cs Outdated Show resolved Hide resolved

mandel-macaque added 2 commits July 18, 2022 11:16

Apply suggestions.

42c877a

Merge branch 'xcode14' into watchkit-xcode14

28d322f

tj-devel709 reviewed Jul 18, 2022

View reviewed changes

src/watchkit.cs Outdated Show resolved Hide resolved

src/watchkit.cs Outdated Show resolved Hide resolved

src/watchkit.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Apply suggestions from code review

2a0a188

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

mandel-macaque merged commit 6d47b64 into dotnet:xcode14 Jul 19, 2022

mandel-macaque deleted the watchkit-xcode14 branch July 19, 2022 15:18

Conversation

mandel-macaque commented Jul 18, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

chamons Jul 18, 2022

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Jul 18, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tj-devel709 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 18, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 18, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 18, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 18, 2022

❗ API diff for current PR / commit (Breaking changes)

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ introspection tests

Successes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants