UIMenu.Identifier should probably be a string and not an enum

[PureWeen]

The UIMenu.Identifier property is an enum which makes custom identifiers or generated ones unreachable.

If you create a new menu with the following code

var titleMenu = UIMenu.Create("Title", new UIMenuElement[0]);

The titleMenu.Identifier property will be set to UIMenuIdentifier.None

That means the following code will fail

MenuBuilder
	.InsertChildMenuAtStart(menuContainer, titleMenu.Identifier);

In order to get the string identifier that you need to use with IUIMenuBuilder you have to retrieve it via a selector.

(NSString)titleMenu.PerformSelector(new Selector("identifier"));

[chamons]

This does appear to be the case based upon documentation https://developer.apple.com/documentation/uikit/uimenuidentifier?language=objc

[dalexsoto]

Probably we can keep the usefulness of both doing

diff --git a/src/uikit.cs b/src/uikit.cs
index ab24a2e60..518009dda 100644
--- a/src/uikit.cs
+++ b/src/uikit.cs
@@ -8008,9 +8008,11 @@ namespace UIKit {
 	[DisableDefaultCtor]
 	interface UIMenu {
 
-		[BindAs (typeof (UIMenuIdentifier))]
+		[Wrap ("UIMenuIdentifierExtensions.GetValue (StringIdentifier)", IsVirtual = true)]
+		UIMenuIdentifier Identifier { get; }
+
 		[Export ("identifier")]
-		NSString Identifier { get; }
+		NSString WeakIdentifier { get; }
 
 		[Export ("options")]
 		UIMenuOptions Options { get; }
@@ -8031,9 +8033,13 @@ namespace UIKit {
 		[Export ("menuWithTitle:children:")]
 		UIMenu Create (string title, UIMenuElement [] children);
 
+		[Static]
+		[Wrap ("Create (title, image, UIMenuIdentifierExtensions.GetValue (identifier), options, children)")]
+		UIMenu Create (string title, [NullAllowed] UIImage image, [NullAllowed] UIMenuIdentifier identifier, UIMenuOptions options, UIMenuElement [] children);
+
 		[Static]
 		[Export ("menuWithTitle:image:identifier:options:children:")]
-		UIMenu Create (string title, [NullAllowed] UIImage image, [NullAllowed] [BindAs (typeof (UIMenuIdentifier))] NSString identifier, UIMenuOptions options, UIMenuElement [] children);
+		UIMenu Create (string title, [NullAllowed] UIImage image, [NullAllowed] NSString stringIdentifier, UIMenuOptions options, UIMenuElement [] children);
 
 		[Export ("menuByReplacingChildren:")]
 		UIMenu GetMenuByReplacingChildren (UIMenuElement [] newChildren);

[rolfbjarne]

I think @dalexsoto's suggestion would work (maybe name the new property WeakIdentifier instead of StringIdentifier, to follow the pattern from elsewhere?), and it shouldn't be a breaking change either.