Updated libmf and corresponding MatrixFactorizationSimpleTrainAndPredict() baselines per build #5121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ict() baselines per build
test/Microsoft.ML.Tests/TrainerEstimators/MatrixFactorizationTests.cs
Outdated
Show resolved
Hide resolved
harishsk
reviewed
May 13, 2020
| @@ -54,7 +54,6 @@ public void MatrixFactorization_Estimator() | |||
| } | |||
|
|
|||
| [MatrixFactorizationFact] | |||
Contributor
There was a problem hiding this comment.
Is MatrixFactorizationFact needed? #Resolved
Contributor
Author
There was a problem hiding this comment.
Actually it is not! Currently, MatrixFactorizationFact is just an EnvironmentSpecificFactAttribute that always returns true with IsEnvironmentSupported(). In a seperate PR, I'll be marking these MatrixFactorizationFact marked tests as Fact, and if possible, remove the MatrixFactorizationFact from the codebase all together. #Resolved
Contributor
Codecov Report
@@ Coverage Diff @@
## master #5121 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 995 995
Lines 179316 179318 +2
Branches 19298 19298
=======================================
+ Hits 135479 135482 +3
- Misses 38572 38575 +3
+ Partials 5265 5261 -4
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4874
This PR updates the libmf submodule, where its recent changes in libmf PR #41 and PR #42 address the shuffling of values in a given matrix.
The C++ function
void random_shuffle(_RanIt _First, _RanIt _Last)is implemented differently on Windows vs. MacOS vs. Linux. This resulted in inconsistent results on MacOS and more-predictable yet still inconsistent results on Linux. As a result, a given matrix factorization problem, even with a constant seed, produced differing MSEs between each run on each system. The libmf codebase has been updated to prevent this, and baseline MSE values in the unit testMatrixFactorizationSimpleTrainAndPredict()have been updated to reflect this.