Skip to content

Fix for NgramTransform #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kere-nel merged 1 commit into from
Feb 7, 2020
Merged

Fix for NgramTransform #4813

kere-nel merged 1 commit into from
Feb 7, 2020

Conversation

@kere-nel
Copy link
Contributor

@kere-nel kere-nel commented Feb 7, 2020

  • Casting UInt16 -> Int64 inside NgramTransform, since it may now receive UInt16 keys from TokeningByCharacters

@kere-nel kere-nel requested a review from a team as a code owner February 7, 2020 22:15
@kere-nel kere-nel merged commit 9fe474d into dotnet:master Feb 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@harishsk harishsk harishsk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kere-nel @harishsk