Added onnx export support for SlotsDroppingTransformer#4562
Merged
harishsk merged 7 commits intodotnet:masterfrom Jan 7, 2020
harishsk:slotsdropper
Merged
Added onnx export support for SlotsDroppingTransformer#4562harishsk merged 7 commits intodotnet:masterfrom harishsk:slotsdropper
harishsk merged 7 commits intodotnet:masterfrom
harishsk:slotsdropper
Conversation
…ssifiers and calibrators due to problems resulting from upgrading the op set version to 11
Codecov Report
@@ Coverage Diff @@
## master #4562 +/- ##
==========================================
+ Coverage 75.64% 75.65% +<.01%
==========================================
Files 938 938
Lines 168618 168715 +97
Branches 18208 18219 +11
==========================================
+ Hits 127554 127642 +88
- Misses 36037 36046 +9
Partials 5027 5027
|
ganik
reviewed
Jan 7, 2020
| new CountFeatureSelectingEstimator.ColumnOptions("FeatureSelectDouble", "VectorDouble", count: 1), | ||
| new CountFeatureSelectingEstimator.ColumnOptions("ScalFeatureSelectMissing690", "ScalarFloat", count: 690), | ||
| new CountFeatureSelectingEstimator.ColumnOptions("ScalFeatureSelectMissing100", "ScalarFloat", count: 100), | ||
| new CountFeatureSelectingEstimator.ColumnOptions("VecFeatureSelectMissing690", "VectorDouble", count: 690), |
Member
There was a problem hiding this comment.
VecFeatureSelectMissing690 [](start = 66, length = 26)
Why such strange names?
Member
There was a problem hiding this comment.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work required the use of ConstantOfShape operator from onnx which has an attribute of type Tensor. Most operators have attributes that are of primitive types (int, float, etc). ML.NET Onnx converter coded didnt have support to add attributes of tensor types.
Therefore this PR includes the support for adding tensor type attributes along with the necessary code and tests for SlotsDroppingTransformer.