[Java.Interop.Tools.JavaCallableWrappers] remove all usage of MD5 #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Fixes: dotnet/android#3844 |
Fixes: dotnet/android#3844 This adds `[Obsolete]` (with `error:true`) to: * `PackageNamingPolicy.LowercaseHash` * `PackageNamingPolicy.LowercaseMD5` If these values are encountered at runtime a `NotSupportedException` will be thrown. Most of the remaining changes were updates to tests. Upstream in xamarin/xamarin-android, we will likely need to emit a new build error with an error code. Other changes: * I removed a place `BaseGeneratorTest.cs` was using `MD5.Create()`. * This exposed a place we need to reset the initial state of `Crc64` when an instance is reused for hashing.
jonathanpeppers
force-pushed
the
remove-md5
branch
from
dfddf8f to
73d407f
Compare
jonpryor
pushed a commit
that referenced
this pull request
Nov 8, 2019
Context: dotnet/android#3844 Context: dotnet/android@88a1d6c Entirely remove support for MD5 output, so that we can reliably use Xamarin.Android on machines with FIPS enalbed. This adds `[Obsolete (..., error:true)]` to: * `PackageNamingPolicy.LowercaseHash` * `PackageNamingPolicy.LowercaseMD5` If these values are encountered at runtime a `NotSupportedException` will be thrown. Most of the remaining changes were updates to tests. Upstream in xamarin/xamarin-android, we will likely need to emit a new build error with an error code. Other changes: * I removed a place `BaseGeneratorTest.cs` was using `MD5.Create()`. * This exposed a place we need to reset the initial state of `Crc64` when an instance is reused for hashing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
[Obsolete](witherror:true) to:PackageNamingPolicy.LowercaseHashPackageNamingPolicy.LowercaseMD5If these values are encountered at runtime a
NotSupportedExceptionwill be thrown.
Most of the remaining changes were updates to tests. Upstream in
xamarin/xamarin-android, we will likely need to emit a new build error
with an error code.
Other changes:
BaseGeneratorTest.cswas usingMD5.Create().Crc64when an instance is reused for hashing.