-
Notifications
You must be signed in to change notification settings - Fork 437
[master] Update dependencies from dotnet/runtime #6876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Update dependencies from dotnet/runtime #6876
Conversation
…0319.13 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20169.13 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20169.13 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20169.13 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20169.13 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20169.13 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20169.13
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…0320.8 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20170.8 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20170.8 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20170.8 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20170.8 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20170.8 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20170.8
…0321.6 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20171.6 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20171.6 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20171.6 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20171.6 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20171.6 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20171.6
…0322.1 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20172.1 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20172.1 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20172.1 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20172.1 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20172.1 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20172.1
…0324.1 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20174.1 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20174.1 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20174.1 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20174.1 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20174.1 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20174.1
…0324.7 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20174.7 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20174.7 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20174.7 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20174.7 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20174.7 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20174.7
…0325.10 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20175.10 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20175.10 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20175.10 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20175.10 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20175.10 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20175.10
…0326.12 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20176.12 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20176.12 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20176.12 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20176.12 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20176.12 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20176.12
…0328.1 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20178.1 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20178.1 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20178.1 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20178.1 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20178.1 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20178.1
…0329.1 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20179.1 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20179.1 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20179.1 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20179.1 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20179.1 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20179.1
…0330.1 - Microsoft.NETCore.Platforms - 5.0.0-preview.3.20180.1 - Microsoft.NETCore.DotNetHostResolver - 5.0.0-preview.3.20180.1 - Microsoft.NETCore.App.Host.win-x64 - 5.0.0-preview.3.20180.1 - Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20180.1 - Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20180.1 - Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20180.1
|
@mmitche do you have any idea of what's going on here? We're getting this failure across many insertion PRs. |
Yeah, seemed odd I noticed...I'm looking into it. |
Looks like it's only happening in the Linux legs. It doesn't appear to be the same error as the other insertions. Could potentially be a runtime bug? @jeffschwMSFT do you have someone who could take a look at this? |
|
Also seen in p3 #7005 |
|
It looks like a native heap corruption. Maybe it would be worth trying to run dotnet with Valgrind to see if it catches something. |
|
Btw, is there a core dump available for that crash? |
|
I was able to repro it locally. Here is a stack trace from a local core dump that has more detail on what was running. |
|
I've tried valgrind, it seems to have found some invalid memory write in CorUnix::InternalSetThreadDescription, which was added recently. I am looking into that. |
|
I've found the issue, it is here: |
|
Valgrind rocks, it gave me the answer on a silver plate. See how it showed me where in the code the invalid write happened and then it showed me where was the block of memory behind which we've written allocated: |
|
@janvorli Awesome! Can you prepare a fix for both master and preview3 |
|
I am just working on the master one. |
|
Looks like this already went in with the auto-merge of #7018 which included the fixed runtime build. |
|
Yup, closing this one in favor of #7018 |
|
We think the duplicated master branch dependency PRs have something to do with the rename of the repo. |
This pull request updates the following dependencies
From https://github.com/dotnet/runtime