Skip to content

Conversation

@directhex
Copy link

@directhex directhex requested a review from a team as a code owner February 26, 2024 15:30
@directhex directhex enabled auto-merge February 26, 2024 16:12
@directhex directhex merged commit a885953 into dotnet:main Feb 26, 2024
@tmds
Copy link
Member

tmds commented Feb 26, 2024

We used to pass this to all projects using (from release/8.0.1xx):

<StandardSourceBuildArgs>$(StandardSourceBuildArgs) /p:SourceBuildUseMonoRuntime=$(SourceBuildUseMonoRuntime)</StandardSourceBuildArgs>

On the main branch there is now:

<BuildArgs Condition="'$(SourceBuildUseMonoRuntime)' == 'true'">$(BuildArgs) /p:SourceBuildUseMonoRuntime=$(SourceBuildUseMonoRuntime)</BuildArgs>

Is this doing something different than before, so that this change is required?

@tmds
Copy link
Member

tmds commented Feb 26, 2024

If this is for making --usemonoruntime work when not specifying --source-build, then the fix may be to not make this BuildArgs assignment conditional on "'$(DotNetBuildSourceOnly)' == 'true'".

SourceBuildUseMonoRuntime affects other repos too (aspnetcore and installer).

@directhex
Copy link
Author

Urgh, not sure how I missed the Directory.Build.Props handling of this.

@ViktorHofer
Copy link
Member

If this property doesn't just affect source-build then the name is misleading and should be updated.

@directhex
Copy link
Author

You're right, of course, but coordinating property renames across multiple repos is horrible.

@ViktorHofer
Copy link
Member

Can you please file a tracking issue so that this doesn't get lost in /dev/null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VMR] investigate whether Mono builds are genuinely producing Mono-based SDKs

4 participants