[release/5.0.4xx] Backport x64 on ARM64 installer changes #12278
Conversation
# Conflicts: # eng/Versions.props # src/finalizer_shim/finalizer_shim.csproj
ericstj
requested review from
NikolaMilosavljevic,
hoyosjs,
joeloff and
sfoslund
|
Nice. The error message is clear. However, we can be more specific and say "Intel-based Mac". That's the language Apple uses. x64 is more Windows/Microsoft language. Not a big deal either way. The correct casing is actually "Arm64" when used in prose.
There are two periods in a row. The error message in the log and the UI are not the same. Align them? |
|
The log is not independent. We cannot make that have a different value. I noticed the two periods as well. Not sure why MacOS does that, it's just the way it gets represented in the log. I will fix up the wording. |
|
Another thing to note here is that the x86, x64, and Arm64 SDKs are all getting this blocker on Windows for both 3.1 and 5.0. Let me know if anyone feels differently. I know that it's a little funny to have an Arm64 SDK that blocks installation on Arm64 but that felt to me like the best thing to do given our support policy. That's also why I choose the verbiage "not supported on Arm64". |
| </bal:Condition> | ||
|
|
||
| <bal:Condition Message="This product is not supported on Arm64."> | ||
| WixBundleInstalled OR (NOT NativeMachine = $(var.NativeMachine_arm64)) OR DOTNETALLOWINSTALLONARM64 |
There was a problem hiding this comment.
DOTNETALLOWINSTALLONARM64 needs to be defined an overridable variable for users to pass it to the bundle.
* Remove writing InstallLocation from SDK, it will be handled by host * Update WiX to signed build (dotnet#12078) # Conflicts: # eng/Versions.props # src/finalizer_shim/finalizer_shim.csproj * Update WiX to 3.14.0.5722 (dotnet#12252) * Add installation checks to prevent install on ARM64 * Update wording of blockers * Ensure we allow specifying DOTNETALLOWINSTALLONARM64 Co-authored-by: Jacques Eloff <[email protected]>
* [release/5.0.4xx] Backport x64 on ARM64 installer changes (#12278) * Remove writing InstallLocation from SDK, it will be handled by host * Update WiX to signed build (#12078) # Conflicts: # eng/Versions.props # src/finalizer_shim/finalizer_shim.csproj * Update WiX to 3.14.0.5722 (#12252) * Add installation checks to prevent install on ARM64 * Update wording of blockers * Ensure we allow specifying DOTNETALLOWINSTALLONARM64 Co-authored-by: Jacques Eloff <[email protected]> * Permit installation of ARM64 SDK * Only block installing x64 SDK on ARM64 Co-authored-by: Jacques Eloff <[email protected]>
5 participants
This is a cherry-pick of the following 6.0 changes to support blocking installation on ARM64, and moving product detection keys to the host installer.
This also adds installation blocks to both the MacOs and Windows installers.
On Mac:
On Windows:
