Repository navigation
Match a path-mapped file name against the solution, not the current directory #20519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xperiandri
wants to merge
16
commits into
dotnet:main
Choose a base branch
from
xperiandri:fix/pathmap-relative-document-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1f3ab95
Build multi-project and multi-target Roslyn solutions in FSharp.Edito…
xperiandri 22958f3
Test navigation into a project built with a path map
xperiandri f944e80
Match a range's file against the solution, not the current directory
xperiandri 764f61e
Link the release note to PR #20519
xperiandri 927f4c8
Recognise a mapped name as the file a document holds
xperiandri 29d50af
Keep a mapped name from narrowing a search to a file it only resembles
xperiandri d898f45
Normalise a mapped name once, not once per document
xperiandri dec4c09
Resolve every range's file the way a mapped name needs
xperiandri 62e4498
Take the shared test fixture as #20462 lands it
xperiandri 5533ade
Keep the shared fixture's results private
xperiandri ecd4890
Take a mapped name for a file only in the source of its own assembly
xperiandri 96379b9
Match the release notes to the merge with main
xperiandri 40599c0
Keep one release note line for the path map fix
xperiandri b0652f3
Keep Quick Info links and consumers of the assembly file beside the m…
xperiandri e8f798f
Compact the path map navigation change
xperiandri d304595
Compare the reached file names with the collection assert instead of …
xperiandri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖🕵️ [P2] Find All References/Rename cancelled when a C# project references the same DLL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At
d304595, when an F# library's source is loaded and both F# and C# projects reference its DLL, the expanded search scope includes the C# project and sends it into F# snapshot creation. A fresh probe using a real imported symbol and the pinned selection/filter/guard code passes for the base scoped search but throwsOperationCanceledException("Project is not a FSharp project.")for the head; this was not a full editor FAR/Rename run. Perhaps exclude non-F# projects before creating F# snapshots while preserving the newly included F# binary consumers, with a mixed-language regression test.