Skip to content

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jun 1, 2025

Description

Fixes # (issue, if applicable)

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@edgarfgp edgarfgp changed the title use errorR instead of error in CheckExpressions when possible. use errorR instead of error in CheckDeclarations when possible. Jun 1, 2025
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Jun 4, 2025

@T-Gro Something is not working with updating test baselines. I keep trying export TEST_UPDATE_BSL=1 and then dotnet test the project but no luck. Any chance you can help me with this ?

@edgarfgp edgarfgp marked this pull request as ready for review June 6, 2025 05:36
@edgarfgp edgarfgp requested a review from a team as a code owner June 6, 2025 05:36
@edgarfgp edgarfgp marked this pull request as draft June 6, 2025 05:36
@T-Gro
Copy link
Member

T-Gro commented Jun 6, 2025

@T-Gro Something is not working with updating test baselines. I keep trying export TEST_UPDATE_BSL=1 and then dotnet test the project but no luck. Any chance you can help me with this ?

Some tests are only running on 472 desktop framework, can't this be the case?

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Jun 6, 2025
@T-Gro T-Gro marked this pull request as ready for review June 6, 2025 08:13
@T-Gro T-Gro merged commit 013a716 into dotnet:main Jun 6, 2025
39 checks passed
@auduchinok
Copy link
Member

@T-Gro It got merged a bit too quick :(

@edgar Could you add some tests, please?
Something similar to #16429 would be really great, if you can check that some previously skipped parts are now being analyzed properly.

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Jun 6, 2025

@T-Gro It got merged a bit too quick :(

@edgar Could you add some tests, please? Something similar to #16429 would be really great, if you can check that some previously skipped parts are now being analyzed properly.

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants