Better ranges for CE let! and use! error reporting.#17712
Merged
vzarytovskii merged 9 commits intodotnet:mainfrom Sep 23, 2024
edgarfgp:better-ranges-for-ce-error-reporting
Merged
Better ranges for CE let! and use! error reporting.#17712vzarytovskii merged 9 commits intodotnet:mainfrom edgarfgp:better-ranges-for-ce-error-reporting
let! and use! error reporting.#17712vzarytovskii merged 9 commits intodotnet:mainfrom
edgarfgp:better-ranges-for-ce-error-reporting
Conversation
Contributor
❗ Release notes required
|
let! and use! error reporting.
psfinaki
reviewed
Sep 19, 2024
edgarfgp
commented
Sep 20, 2024
edgarfgp
commented
Sep 20, 2024
vzarytovskii
approved these changes
Sep 21, 2024
psfinaki
reviewed
Sep 23, 2024
tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
Show resolved
Hide resolved
psfinaki
reviewed
Sep 23, 2024
tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
Show resolved
Hide resolved
psfinaki
approved these changes
Sep 23, 2024
Contributor
psfinaki
left a comment
There was a problem hiding this comment.
Thanks Edgar, great job as usual :)
This was referenced Oct 31, 2024
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Better ranges for CE
let!anduse!error reporting. Continuation of #17671Before
let!in an CE builderlet!in aquerybuilderuse!in an CE builderuse!in aquerybuilderAfter
let!in an CE builderlet!in aquerybuilderuse!in an CE builderuse!in aquerybuilderChecklist