Remove check for jagged arrays and add unit tests #13974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
approved these changes
Sep 24, 2022
Contributor
Author
|
Finally green 🎉 |
T-Gro
approved these changes
Sep 26, 2022
Member
T-Gro
left a comment
T-Gro
left a comment
There was a problem hiding this comment.
This looks good, thanks for the quick turnaround.
If we need/want a nicer type syntax for jagged arrays (but not arrayNd), we can put this back with modified naming.
I was having some thoughts about ( (array^N)), but that would unlikely be beneficial to anyone...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses @dsyme in #12013 (comment) Regarding jagged arrays