avoiding exception when redirect stdout(#21) #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoeRobich
reviewed
Feb 27, 2019
src/Logging/SimpleConsoleLogger.cs
Outdated
|
|
||
| namespace Microsoft.CodeAnalysis.Tools.Logging | ||
| { | ||
| internal class SimpleTerminal : ITerminal |
Member
There was a problem hiding this comment.
Move this class to a separate file
JoeRobich
reviewed
Feb 27, 2019
Member
JoeRobich
left a comment
JoeRobich
left a comment
There was a problem hiding this comment.
Looking at this a bit more. I think the better solution might be to keep a reference to console in the SimpleConsoleLogger and based on whether _terminal is null call a LogToTerminal or LogToConsole method from Log.
remove SimpleTerminal because it is no longer used.
Contributor
Author
|
fixes are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related on #21.
creating simple terminal instance for logging if GetTerminal returns null.