Fix serialization of UserInputRequest/ResponseContent #6962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialization of variables typed as UserInputRequestContent / UserInputResponseContent would fail, because JsonSerializer doesn't recognize them as part of a hierarchy.
Member
Author
|
cc: @crickman |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a JSON serialization issue for UserInputRequestContent and UserInputResponseContent types by adding proper polymorphic serialization support. The fix ensures that derived types in these hierarchies can be correctly serialized and deserialized through JsonSerializer.
Key changes:
- Added
JsonPolymorphicandJsonDerivedTypeattributes to base content classes - Registered base types in the default JSON serializer context
- Added comprehensive serialization roundtrip tests for all affected content types
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
UserInputRequestContent.cs |
Added polymorphic JSON serialization attributes for derived type support |
UserInputResponseContent.cs |
Added polymorphic JSON serialization attributes for derived type support |
AIJsonUtilities.Defaults.cs |
Registered base content types in default JSON context |
TestJsonSerializerContext.cs |
Added array type registrations for test serialization |
UserInputRequestContentTests.cs |
Added test validating serialization of request content and derived types |
UserInputResponseContentTests.cs |
Added test validating serialization of response content and derived types |
FunctionApprovalRequestContentTests.cs |
Added serialization roundtrip test |
FunctionApprovalResponseContentTests.cs |
Added serialization roundtrip test |
HostedFileContentTests.cs |
Added serialization roundtrip test |
HostedVectorStoreContentTests.cs |
Added serialization roundtrip test |
McpServerToolResultContentTests.cs |
Added serialization roundtrip test |
TextContentTests.cs |
Added serialization roundtrip test |
TextReasoningContentTests.cs |
Added serialization roundtrip test |
UsageContentTests.cs |
Added serialization roundtrip test |
...ibraries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/UserInputRequestContentTests.cs
Show resolved
Hide resolved
...braries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/UserInputResponseContentTests.cs
Outdated
Show resolved
Hide resolved
…ents/UserInputResponseContentTests.cs Co-authored-by: Copilot <[email protected]>
stephentoub
commented
Oct 25, 2025
...braries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/UserInputResponseContentTests.cs
Outdated
Show resolved
Hide resolved
…ents/UserInputResponseContentTests.cs
eiriktsarpalis
approved these changes
Oct 27, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Nov 1, 2025
* Fix serialization of UserInputRequest/ResponseContent Serialization of variables typed as UserInputRequestContent / UserInputResponseContent would fail, because JsonSerializer doesn't recognize them as part of a hierarchy. * Update test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/UserInputResponseContentTests.cs Co-authored-by: Copilot <[email protected]> * Update test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/UserInputResponseContentTests.cs --------- Co-authored-by: Copilot <[email protected]>
jeffhandley
pushed a commit
that referenced
this pull request
Nov 2, 2025
* Fix serialization of UserInputRequest/ResponseContent Serialization of variables typed as UserInputRequestContent / UserInputResponseContent would fail, because JsonSerializer doesn't recognize them as part of a hierarchy. * Update test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/UserInputResponseContentTests.cs Co-authored-by: Copilot <[email protected]> * Update test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/UserInputResponseContentTests.cs --------- Co-authored-by: Copilot <[email protected]>
This was referenced Nov 11, 2025
Merged
Merged
This was referenced Nov 17, 2025
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization of variables typed as UserInputRequestContent / UserInputResponseContent would fail, because JsonSerializer doesn't recognize them as part of a hierarchy.
Microsoft Reviewers: Open in CodeFlow