Skip to content

Improve CPU metrics calculations for CgroupV2 #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evgenyfedorov2 merged 15 commits into from
Apr 16, 2025

Resolving comments and adding tests.

eb4fbc1
Select commit
Loading
Failed to load commit list.
Merged

Improve CPU metrics calculations for CgroupV2 #6289

Resolving comments and adding tests.
eb4fbc1
Select commit
Loading
Failed to load commit list.
Azure Pipelines / extensions-ci (Correctness WarningsCheck) failed Apr 15, 2025 in 7m 31s

Correctness WarningsCheck failed

6 errors / 0 warnings

Annotations

Check failure on line 100 in src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs#L100 

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs(100,12): error CS8618: (NETCORE_ENGINEERING_TELEMETRY=Build) Non-nullable field '_cachedCgroupPath' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check failure on line 136 in src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs#L136 

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs(136,1): error IDE0055: (NETCORE_ENGINEERING_TELEMETRY=Build) Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)

Check failure on line 97 in src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs#L97 

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs(97,5): error SA1515: (NETCORE_ENGINEERING_TELEMETRY=Build) Single-line comment should be preceded by blank line (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1515.md)

Check failure on line 100 in src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs#L100 

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs(100,12): error CS8618: (NETCORE_ENGINEERING_TELEMETRY=Build) Non-nullable field '_cachedCgroupPath' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check failure on line 136 in src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs#L136 

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationParserCgroupV2.cs(136,1): error IDE0055: (NETCORE_ENGINEERING_TELEMETRY=Build) Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
View more details on Azure Pipelines