Skip to content

Conversation

@AndriySvyryd
Copy link
Member

No description provided.

@AndriySvyryd AndriySvyryd requested a review from a team January 30, 2025 01:14
@AndriySvyryd AndriySvyryd enabled auto-merge (squash) January 30, 2025 01:14
@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 30, 2025

Notice this change:

await sqlConnection.OpenAsync(SqlConnectionOverrides.OpenWithoutRetry, cancellationToken);

@roji
Copy link
Member

roji commented Jan 30, 2025

@AndriySvyryd I'm no longer sure where we're at with the disabling retries thing and async...

@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 30, 2025

There was a regression with Open, was fixed in 5.1.6.

Async has never supported the OpenWithoutRetry parameter until now

@roji
Copy link
Member

roji commented Jan 30, 2025

Right, so we need to react and add this to the right OpenAsync calls...

@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 30, 2025

// Note: Not needed for the Async overload: see https://github.com/dotnet/SqlClient/issues/615
- only if 6.0 is LTS I guess?

@AndriySvyryd
Copy link
Member Author

We'll revert this if we need to before the release.

@AndriySvyryd AndriySvyryd disabled auto-merge February 3, 2025 20:50
@AndriySvyryd AndriySvyryd merged commit a130def into main Feb 3, 2025
5 of 7 checks passed
@AndriySvyryd AndriySvyryd deleted the UpdateSqlClient branch February 3, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants