Fixes around identifier and type mappings for ValuesExpression#33439
Merged
Conversation
Contributor
|
Test with Union should work. For that we ignore the original identifiers (as long as there were some to begin with) and use the projection itself as identifier. @roji |
roji
force-pushed
the
InlineCollectionStuff
branch
from
897d104 to
892fe6a
Compare
roji
force-pushed
the
InlineCollectionStuff
branch
from
892fe6a to
2b507ab
Compare
Member
Author
|
@maumar thanks for the tip, makes sense! Pushed the UNION-based test, and some other fixes, should be ready for review. |
maumar
approved these changes
Mar 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maumar the identifier fix doesn't have a test for it - not sure I can come up with a test case that doesn't also involve a set operation, which is blocked by other issues (#33410 (comment)).
Closes #33436
Closes #33438