Skip to content

Centralize and clean up diagnostic IDs#33415

Merged
roji merged 1 commit into
dotnet:mainfrom
roji:DiagnosticIds
Mar 28, 2024
Merged

Centralize and clean up diagnostic IDs#33415
roji merged 1 commit into
dotnet:mainfrom
roji:DiagnosticIds

Conversation

@roji
Copy link
Copy Markdown
Member

@roji roji commented Mar 27, 2024

Centralizes all diagnostic IDs in a new public EFDiagnostics class:

public static class EFDiagnostics
{
    public const string InternalUsage = "EF1001";
    public const string InterpolatedStringUsageInRawQueries = "EF1002";
    public const string SuppressUninitializedDbSetRule = "EFSPR1001";

    // Diagnostics for [Experimental]
    public const string ExperimentalApi = "EF9001";
    public const string ProviderExperimentalApi = "EF9002";
    public const string PrecompiledQueryExperimental = "EF9100";
}

So EF9xxx is for all the experimental stuff, EF9001 is for user-facing experimental APIs which don't have a dedicated ID, EF9002 is for provider-facing ones, and EF9100 and above is for specific experimental feature IDs (such as precompiled queries).

@roji roji requested a review from a team March 27, 2024 16:01
@roji roji merged commit 8487da8 into dotnet:main Mar 28, 2024
@roji roji deleted the DiagnosticIds branch March 28, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants