Update System.Formats.Tar docs #8375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
This comment was marked as outdated.
This comment was marked as outdated.
carlossanlop
commented
Sep 13, 2022
Contributor
Author
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Reverting some of the texts that had already gone through language review.
carlossanlop
commented
Sep 13, 2022
carlossanlop
commented
Sep 13, 2022
carlossanlop
commented
Sep 13, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
approved these changes
Sep 13, 2022
Co-authored-by: Genevieve Warren <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Genevieve Warren <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Much better, @gewarren. Ready to merge!
|
carlossanlop
added a commit
that referenced
this pull request
Sep 14, 2022
* Update System.Formats.Tar docs (#8375) * Update tar docs * Apply suggestions from code review * Few more * Update xml/System.Formats.Tar/GnuTarEntry.xml * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> * Update xml/System.Formats.Tar/GnuTarEntry.xml Co-authored-by: Genevieve Warren <[email protected]> * Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry) Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Apply suggestions from code review * Fix bullet lists * Merge markdowns Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync System.Formats.Tar docs with the latest changes in source. Also created a runtime PR to backport the docs reviewed content: dotnet/runtime#75386