Skip to content

Conversation

@carlossanlop
Copy link
Contributor

Note: Some of the APIs in this PR were the ones reported as still being undocumented in dotnet/runtime.

@dotnet/area-extensions-hosting
@dotnet/area-extensions-logging
@dotnet/area-system-componentmodel
System.Data @ajcvickers @DavoudEshtehari @David-Engel
System.Formats.Tar @carlossanlop
@dotnet/area-system-io
@dotnet/area-system-io-compression
System.Net.Security @dotnet/ncl @dotnet/area-system-security
@dotnet/area-system-numerics
System.GC @Maoni0 @dotnet/gc
@dotnet/area-system-runtime
@dotnet/area-system-runtime-compilerservices
System.Runtime.InteropServices @dotnet/interop-contrib
@dotnet/area-system-security
@dotnet/area-system-text-json

Co-authored-by: Genevieve Warren <[email protected]>
@opbld34

This comment was marked as outdated.

@opbld34

This comment was marked as outdated.

carlossanlop and others added 2 commits July 20, 2022 20:06
@opbld33

This comment was marked as outdated.

@opbld34

This comment was marked as outdated.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the warning - I couldn't find an API called JsonPropertyInfo.Order.

Co-authored-by: Genevieve Warren <[email protected]>
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.IO* LGTM!

@opbld31
Copy link

opbld31 commented Jul 21, 2022

Docs Build status updates of commit 43ec01e:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Text.Json.Serialization.Metadata/JsonTypeInfo.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Hosting/HostAbortedException.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/SystemdHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/ConsoleLoggerOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/ConsoleLoggerQueueFullMode.xml ✅Succeeded View
xml/System.ComponentModel/DateOnlyConverter.xml ✅Succeeded View
xml/System.ComponentModel/HalfConverter.xml ✅Succeeded View
xml/System.ComponentModel/Int128Converter.xml ✅Succeeded View
xml/System.ComponentModel/TimeOnlyConverter.xml ✅Succeeded View
xml/System.ComponentModel/UInt128Converter.xml ✅Succeeded View
xml/System.Data.Common/DbDataSource.xml ✅Succeeded View
xml/System.Formats.Tar/GnuTarEntry.xml ✅Succeeded View
xml/System.Formats.Tar/PaxGlobalExtendedAttributesTarEntry.xml ✅Succeeded View
xml/System.Formats.Tar/PaxTarEntry.xml ✅Succeeded View
xml/System.Formats.Tar/TarEntry.xml ✅Succeeded View
xml/System.Formats.Tar/TarEntryFormat.xml ✅Succeeded View
xml/System.Formats.Tar/TarWriter.xml ✅Succeeded View
xml/System.Formats.Tar/UstarTarEntry.xml ✅Succeeded View
xml/System.Formats.Tar/V7TarEntry.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchiveEntry.xml ✅Succeeded View
xml/System.IO/Directory.xml ✅Succeeded View
xml/System.IO/File.xml ✅Succeeded View
xml/System.IO/FileStreamOptions.xml ✅Succeeded View
xml/System.IO/FileSystemInfo.xml ✅Succeeded View
xml/System.IO/UnixFileMode.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.Text.Json.Serialization.Metadata/JsonTypeInfo.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Json.Serialization.Metadata.JsonPropertyInfo.Order'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Json.Serialization.Metadata.JsonPropertyInfo.Order'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop carlossanlop enabled auto-merge (squash) July 21, 2022 17:32
@carlossanlop carlossanlop merged commit 22c71b5 into dotnet:main Jul 21, 2022
@carlossanlop carlossanlop deleted the PortPrev6 branch July 21, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.