Skip to content

Document NullabilityInfoContext thread-safety constraints #12264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gewarren merged 6 commits into from
Jan 27, 2026
Merged

Document NullabilityInfoContext thread-safety constraints #12264

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e67914a
Initial plan
Copilot Jan 27, 2026
87161f5
Document thread-safety concerns for NullabilityInfoContext
Copilot Jan 27, 2026
f4705b8
Update xml/System.Reflection/NullabilityInfoContext.xml
gewarren Jan 27, 2026
d103db7
Update thread-safety documentation per review feedback
Copilot Jan 27, 2026
14fc0d7
Remove thread-safety remarks from individual methods
Copilot Jan 27, 2026
961c4b6
Add threadsafe sections to Create methods
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions xml/System.Reflection/NullabilityInfoContext.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<Docs>
<summary>Provides APIs for populating nullability information and context from reflection members: <see cref="T:System.Reflection.ParameterInfo" />, <see cref="T:System.Reflection.FieldInfo" />, <see cref="T:System.Reflection.PropertyInfo" />, and <see cref="T:System.Reflection.EventInfo" />.</summary>
<remarks>To be added.</remarks>
<threadsafe>This type is not thread-safe. The <see cref="Overload:System.Reflection.NullabilityInfoContext.Create" /> methods can't be called concurrently from multiple threads, as they use a non-concurrent cache internally. Concurrent calls can result in an <see cref="T:System.InvalidOperationException" />. If you need to use <see cref="T:System.Reflection.NullabilityInfoContext" /> from multiple threads, create a separate instance for each thread or use external synchronization.</threadsafe>
</Docs>
<Members>
<Member MemberName=".ctor">
Expand Down Expand Up @@ -75,7 +76,7 @@
<param name="eventInfo">The event for which to populate nullability information.</param>
<summary>Populates a <see cref="T:System.Reflection.NullabilityInfo" /> for the given <see cref="T:System.Reflection.EventInfo" />. If the <c>nullablePublicOnly</c> feature is set for an assembly, like it does in the .NET SDK, the private and/or internal member's nullability attributes are omitted, and the API will return the <see cref="F:System.Reflection.NullabilityState.Unknown" /> state.</summary>
<returns>A <see cref="T:System.Reflection.NullabilityInfo" /> instance.</returns>
<remarks>To be added.</remarks>
<remarks>This method is not thread-safe. Don't call it concurrently from multiple threads, as it uses a non-concurrent cache internally. Concurrent calls can result in an <see cref="T:System.InvalidOperationException" />.</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="eventInfo" /> is <see langword="null" />.</exception>
</Docs>
Expand Down Expand Up @@ -106,7 +107,7 @@
<param name="fieldInfo">The field for which to populate the nullability information.</param>
<summary>Populates a <see cref="T:System.Reflection.NullabilityInfo" /> for the given <see cref="T:System.Reflection.FieldInfo" />. If the <c>nullablePublicOnly</c> feature is set for an assembly, like it does in the .NET SDK, the private and/or internal member's nullability attributes are omitted, and the API will return the <see cref="F:System.Reflection.NullabilityState.Unknown" /> state.</summary>
<returns>A <see cref="T:System.Reflection.NullabilityInfo" /> instance.</returns>
<remarks>To be added.</remarks>
<remarks>This method is not thread-safe. Don't call it concurrently from multiple threads, as it uses a non-concurrent cache internally. Concurrent calls can result in an <see cref="T:System.InvalidOperationException" />.</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="fieldInfo" /> is <see langword="null" />.</exception>
</Docs>
Expand Down Expand Up @@ -137,7 +138,7 @@
<param name="parameterInfo">The parameter for which to populate the nullability information.</param>
<summary>Populates a <see cref="T:System.Reflection.NullabilityInfo" /> for the given <see cref="T:System.Reflection.ParameterInfo" />. If the <c>nullablePublicOnly</c> feature is set for an assembly, like it does in the .NET SDK, the private and/or internal member's nullability attributes are omitted, and the API will return the <see cref="F:System.Reflection.NullabilityState.Unknown" /> state.</summary>
<returns>A <see cref="T:System.Reflection.NullabilityInfo" /> instance.</returns>
<remarks>To be added.</remarks>
<remarks>This method is not thread-safe. Don't call it concurrently from multiple threads, as it uses a non-concurrent cache internally. Concurrent calls can result in an <see cref="T:System.InvalidOperationException" />.</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="parameterInfo" /> is <see langword="null" />.</exception>
</Docs>
Expand Down Expand Up @@ -168,7 +169,7 @@
<param name="propertyInfo">The property for which to populate the nullability information.</param>
<summary>Populates a <see cref="T:System.Reflection.NullabilityInfo" /> for the given <see cref="T:System.Reflection.PropertyInfo" />. If the <c>nullablePublicOnly</c> feature is set for an assembly, like it does in the .NET SDK, the private and/or internal member's nullability attributes are omitted, and the API will return the <see cref="F:System.Reflection.NullabilityState.Unknown" /> state.</summary>
<returns>A <see cref="T:System.Reflection.NullabilityInfo" /> instance.</returns>
<remarks>To be added.</remarks>
<remarks>This method is not thread-safe. Don't call it concurrently from multiple threads, as it uses a non-concurrent cache internally. Concurrent calls can result in an <see cref="T:System.InvalidOperationException" />.</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="propertyInfo" /> is <see langword="null" />.</exception>
</Docs>
Expand Down