Update http-resilience.md #46361
Merged
Update http-resilience.md #46361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a warning of using ShouldHandle in retry strategy, this is a lesson in our real practice, hope we can help more people.
dotnet-policy-service
bot
added
dotnet-fundamentals/svc
community-contribution
Contributor
Author
|
@IEvangelist , @iliar-turdushev could you please review this PR, just to add a warning comment in the doc, thanks |
IEvangelist
reviewed
May 28, 2025
IEvangelist
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning of using ShouldHandle in retry strategy, this is a lesson in our real practice, hope we can help more people.
In our practice, we add Retry->AttemptTimeout resilience strategies, and we configure the ShouldHandle delegate in retry strategy, but we only take care of the System.TimeoutException, omit the Polly TimeoutRejectedException, this makes all the requests hitting attempt timeout but not able to retry, and downgrade the service's availability.
Internal previews