Skip to content

Version deserialization breaking change #27809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 2 commits into from
Jan 12, 2022
Merged

Version deserialization breaking change #27809

gewarren merged 2 commits into from
Jan 12, 2022

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 12, 2022 •
edited
Loading

Fixes #26292

Preview

@dotnet-bot dotnet-bot added this to the January 2022 milestone Jan 12, 2022
@gewarren gewarren requested review from layomia and tdykstra January 12, 2022 01:26
tdykstra
tdykstra approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 8fc459d into dotnet:main Jan 12, 2022
@gewarren gewarren deleted the version-serialize branch January 12, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdykstra tdykstra tdykstra approved these changes

@layomia layomia Awaiting requested review from layomia

Assignees

No one assigned

Labels

dotnet-fundamentals/svc

Projects

None yet

Milestone

January 2022

Development

Successfully merging this pull request may close these issues.

[Breaking change]: JsonSerializer throws FormatException when deserializing Version types with leading or trailing whitespace

3 participants

@gewarren @tdykstra @dotnet-bot