[Dotnet Monitor] Revert To Logging a single payload (not a list) #3538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te as I investigate other types of metrics
…nterPayload. This still returns a list from the TryGetCounterPayload due to the structure of histogram data (and for our data model we need values to be a double, not a list of doubles).
wiktork
approved these changes
Dec 5, 2022
hoyosjs
approved these changes
Dec 6, 2022
wiktork
pushed a commit
that referenced
this pull request
Jan 27, 2023
wiktork
added a commit
that referenced
this pull request
Jan 30, 2023
…tor (#3587) * [Dotnet Monitor] Ignore - Adding System.Diagnostics.Metrics Support (#3529) * Got basic counter rate end-to-end working - currently in a broken state as I investigate other types of metrics * Leftovers from previous commit * Gauges working for systems diagnostics metrics * Added in histogram, adding in options for maxHistograms and maxTimeSeries * Added in error payloads for logging purposes * Temporarily changed visibility for testing - this may be reverted later * Now handling multiple sessions * Added filtering for counters, instead of allowing all counters for a provider to go through. * Handle observable... errors * Some cleanup, added error event check * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20221129.1 (#3528) [main] Update dependencies from dotnet/source-build-reference-packages Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> * [Dotnet Monitor] Revert To Logging a single payload (not a list) (#3538) * [Feature branch changes, no review] Fixup counter apis (#3559) * Fix ICountersLogger contract * MetadataUpdates * Fixup api protection levels * Fixup tests and add CounterEnded payload * Fixup metadata parsing * [Dotnet-Monitor] [Feature Branch] Switched quantile to Percentile (#3567) * Minor branch cleanup * PR for feature branch * PR feedback * Pr feedback feedback * Convert Histogram to single payload * Tweaks to account for new All flag * Fixed build/test failures from Wiktor's changes * Fix issue with empty quantiles * Initial PR feedback (#3620) * Fixes outdated naming in test --------- Co-authored-by: kkeirstead <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: kkeirstead <[email protected]>
kkeirstead
added a commit
to kkeirstead/diagnostics
that referenced
this pull request
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this feature is in-progress and this PR is going into a feature branch.
@wiktork