-
Notifications
You must be signed in to change notification settings - Fork 387
Add new provider for gc-collect profile #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hoyosjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tommcdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
thanks @hoyosjs! I'm curious why those rundown events are there even though they are not in the list of events we collect for this profile? |
|
Currently dotnet-trace is hardcoded to always request rundown, the
We should generally have an option to skip rundown, I opened #3597 to track it. |
davmason
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Daniel!
|
great, thanks @dramos020 for doing this work, and @davmason for the new issue! |
Adds the profile mentioned in #3521 in order to include private gc events in the gc-collect profile. Can see this working by using the following sample application:
and dotnet-trace to collect a trace:
This results in the following events being generated, making note of the private gc events:
