Dev/mirogers/kudu console #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfalk
reviewed
May 19, 2022
mikelle-rogers
force-pushed
the
dev/mirogers/kudu_console
branch
from
0560b93 to
57b744c
Compare
noahfalk
reviewed
May 24, 2022
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Below is the stack trace that is shown when I tried to access the named pipe using the dotnet-trace ps command on Windows. Microsoft.Diagnostics.NETCore.Client.NamedPipeEnumerationUnauthorizedException: Enumerating \\.\pipe\ is not authorized
---> System.UnauthorizedAccessException: Access to the path '\\.\pipe\' is denied.
at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)
at System.IO.Enumeration.FileSystemEnumerator`1.Init()
at System.IO.Enumeration.FileSystemEnumerator`1..ctor(String directory, Boolean isNormalized, EnumerationOptions options)
at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized)
at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options)
at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
at System.IO.Directory.GetFiles(String path)
at Microsoft.Diagnostics.NETCore.Client.DiagnosticsClient.GetPublishedProcesses() in C:\Users\mirogers\source\repos\diagnostics\src\Microsoft.Diagnostics.NETCore.Client\DiagnosticsClient\DiagnosticsClient.cs:line 313
--- End of inner exception stack trace ---
at Microsoft.Diagnostics.NETCore.Client.DiagnosticsClient.GetPublishedProcesses() in C:\Users\mirogers\source\repos\diagnostics\src\Microsoft.Diagnostics.NETCore.Client\DiagnosticsClient\DiagnosticsClient.cs:line 323
at Microsoft.Internal.Common.Commands.ProcessStatusCommandHandler.ProcessStatus(IConsole console) in C:\Users\mirogers\source\repos\diagnostics\src\Tools\Common\Commands\ProcessStatus.cs:line 126
Microsoft.Diagnostics.NETCore.Client.NamedPipeEnumerationUnauthorizedException: Enumerating \\.\pipe\ is not authorized
---> System.UnauthorizedAccessException: Access to the path '\\.\pipe\' is denied.
at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)
at System.IO.Enumeration.FileSystemEnumerator`1.Init()
at System.IO.Enumeration.FileSystemEnumerator`1..ctor(String directory, Boolean isNormalized, EnumerationOptions options)
at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized)
at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options)
at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
at System.IO.Directory.GetFiles(String path)
at Microsoft.Diagnostics.NETCore.Client.DiagnosticsClient.GetPublishedProcesses() in C:\Users\mirogers\source\repos\diagnostics\src\Microsoft.Diagnostics.NETCore.Client\DiagnosticsClient\DiagnosticsClient.cs:line 313
--- End of inner exception stack trace ---
at Microsoft.Diagnostics.NETCore.Client.DiagnosticsClient.GetPublishedProcesses() in C:\Users\mirogers\source\repos\diagnostics\src\Microsoft.Diagnostics.NETCore.Client\DiagnosticsClient\DiagnosticsClient.cs:line 323
at Microsoft.Internal.Common.Commands.ProcessStatusCommandHandler.ProcessStatus(IConsole console) in C:\Users\mirogers\source\repos\diagnostics\src\Tools\Common\Commands\ProcessStatus.cs:line 126 |
hoyosjs
reviewed
Jul 20, 2022
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClientExceptions.cs
Outdated
Show resolved
Hide resolved
hoyosjs
requested changes
Jul 20, 2022
noahfalk
reviewed
Jul 22, 2022
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs
Outdated
Show resolved
Hide resolved
noahfalk
approved these changes
Jul 22, 2022
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
LGTM modulo the couple comments
hoyosjs
reviewed
Jan 24, 2023
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClientExceptions.cs
Outdated
Show resolved
Hide resolved
hoyosjs
approved these changes
Jan 25, 2023
hoyosjs
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2323
Catch exception and clarify error message. The user does not have access to NamedPipes as a result of how kudu runs applications. Commands that attempt to enumerate NamedPipes will not work.