This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Introduce public setter for Activity #29208
Merged
lmolkova merged 2 commits intodotnet:masterfrom Apr 26, 2018
Merged
Conversation
|
I will take a look today. |
vancem
reviewed
Apr 20, 2018
|
|
||
| private static bool ValidateSetCurrent(Activity activity) | ||
| { | ||
| bool canSet = activity == null || (activity.Id != null && !activity.isFinished); |
There was a problem hiding this comment.
There are potential races here, but I believe the right answer is to simply tolerate them.
Author
There was a problem hiding this comment.
Agree, concurrent usage and modification of Activity.Current should be extremely rare and does not look like a valid scenario
vancem
approved these changes
Apr 20, 2018
Author
|
@dotnet-bot test OSX x64 Debug Build |
Author
|
@dotnet-bot test Packaging All Configurations x64 Debug Build |
Author
|
thanks for the review, @vancem! |
lmolkova
changed the title
2 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ySetterPublic Introduce public setter for Activity.Current Commit migrated from dotnet/corefx@7f7a789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #29207