-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Enable event tracing for Tizen. #14137
Conversation
|
|
@BruceForstall, @Dmitri-Botcharnikov the change looks good, but it looks like we don't have the lttng-ust-dev package installed in the Tizen rootfs we are using and we need to add it. |
|
As @janvorli said, we need to 1) fix rootfs script, and 2) update docker image for ci because lttng-ust-dev is not installed. |
| @@ -1,5 +1,5 @@ | |||
| if(CLR_CMAKE_TARGET_TIZEN_LINUX) | |||
| set(FEATURE_EVENT_TRACE 0) | |||
| set(FEATURE_EVENT_TRACE 1) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to enable this feature, you can simply remove this line.
FEATURE_EVENT_TRACE is set by default on Linux/ARM32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hseok-oh Thank you for suggestion, but I think it's more reliable to explicitly set feature on.
|
@Dmitri-Botcharnikov @BruceForstall @janvorli @hseok-oh I'm now testing with new rootfs with lttng and will update docker image used for Tizen CI if there is no problem. |
|
@hqueue Thank you! IMHO we need to add lttng-ust-dev package to tizen-fetch.sh script. |
|
@Dmitri-Botcharnikov #14173 is merged now. I think Tizen CI will work without problem after rebasing this PR to the latest master. |
86bd187 to
11f057f
Compare
|
@dotnet-bot test Ubuntu16.04 armlb Cross Debug Build please |
|
@dotnet-bot test Tizen armel Cross Release Build please |
|
@hqueue Thank you! |
|
@janvorli Tests have passed; is this good to merge? |
This PR enables generation of LTTng event providers for Tizen platform by default.