Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@Dmitri-Botcharnikov
Copy link

This PR enables generation of LTTng event providers for Tizen platform by default.

@BruceForstall
Copy link

07:06:17 CMake Error at src/pal/src/configure.cmake:1346 (message):
07:06:17   Cannot find liblttng-ust-dev.  Try installing liblttng-ust-dev (or the
07:06:17   appropriate packages for your platform)
07:06:17 Call Stack (most recent call first):
07:06:17   src/pal/src/CMakeLists.txt:5 (include)

@BruceForstall
Copy link

cc @parjong @janvorli

Who is the best to review this?

@janvorli
Copy link
Member

@BruceForstall, @Dmitri-Botcharnikov the change looks good, but it looks like we don't have the lttng-ust-dev package installed in the Tizen rootfs we are using and we need to add it.
Last time the rootfs was updated by @hqueue in a23cd52.

@hseok-oh
Copy link

hseok-oh commented Sep 25, 2017

As @janvorli said, we need to 1) fix rootfs script, and 2) update docker image for ci because lttng-ust-dev is not installed.

@@ -1,5 +1,5 @@
if(CLR_CMAKE_TARGET_TIZEN_LINUX)
set(FEATURE_EVENT_TRACE 0)
set(FEATURE_EVENT_TRACE 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to enable this feature, you can simply remove this line.
FEATURE_EVENT_TRACE is set by default on Linux/ARM32.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hseok-oh Thank you for suggestion, but I think it's more reliable to explicitly set feature on.

@hqueue
Copy link
Member

hqueue commented Sep 25, 2017

@Dmitri-Botcharnikov @BruceForstall @janvorli @hseok-oh I'm now testing with new rootfs with lttng and will update docker image used for Tizen CI if there is no problem.

@Dmitri-Botcharnikov
Copy link
Author

@hqueue Thank you! IMHO we need to add lttng-ust-dev package to tizen-fetch.sh script.

@hqueue
Copy link
Member

hqueue commented Sep 25, 2017

I've just opened #14173. We have to wait CI testing completed for #14173 to see a new docker image working correctly.
It took some time to test rootfs and docker image locally and upload docker image for public use.

@hqueue
Copy link
Member

hqueue commented Sep 26, 2017

@Dmitri-Botcharnikov #14173 is merged now. I think Tizen CI will work without problem after rebasing this PR to the latest master.

@Dmitri-Botcharnikov
Copy link
Author

@dotnet-bot test Ubuntu16.04 armlb Cross Debug Build please

@Dmitri-Botcharnikov
Copy link
Author

@dotnet-bot test Tizen armel Cross Release Build please

@Dmitri-Botcharnikov
Copy link
Author

@hqueue Thank you!

@BruceForstall
Copy link

@janvorli Tests have passed; is this good to merge?

@janvorli janvorli merged commit 485bbd5 into dotnet:master Sep 26, 2017
@Dmitri-Botcharnikov Dmitri-Botcharnikov deleted the tizen-tracing branch September 27, 2017 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants