Repository navigation
Fix @onclick:preventDefault not being respected by Blazor enhanced navigation #70289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Yuvan111
wants to merge
1
commit into
dotnet:main
from
BrundhaVelusamy:52514_preventDefaultNavigation
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
src/Components/Web.JS/src/Rendering/Events/EventDelegatorListeners.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| let clickListenerRegisteredCallback: ((isDispatchingClick: boolean) => void) | undefined; | ||
| let clickDispatchDepth = 0; | ||
|
|
||
| export function setClickListenerRegisteredCallback(callback: typeof clickListenerRegisteredCallback): void { | ||
| clickListenerRegisteredCallback = callback; | ||
| } | ||
|
|
||
| export function notifyGlobalListenerAdded(eventName: string): void { | ||
| if (eventName === 'click') { | ||
| clickListenerRegisteredCallback?.(clickDispatchDepth > 0); | ||
| } | ||
| } | ||
|
|
||
| export function dispatchGlobalEvent(event: Event, listener: EventListener): void { | ||
| if (event.type !== 'click') { | ||
| listener(event); | ||
| return; | ||
| } | ||
|
|
||
| clickDispatchDepth++; | ||
| try { | ||
| listener(event); | ||
| } finally { | ||
| clickDispatchDepth--; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested clicks can bypass enhanced navigation
If a synchronous interactive click re-registers a renderer’s click listener, then triggers another element’s .click(), the inner navigation listener clears the pending reorder. This removes the navigation listener from the outer event’s dispatch snapshot. The outer link then performs a full page load, losing enhanced-navigation behavior.
This reproduced 10/10 times in Chromium using the PR’s event-delegation and navigation-listener code. Controls without the nested click retained interception. Managed interop and enhanced-page fetching were stubbed, so this is DOM-level evidence, not full Blazor E2E verification.
Reordering should wait until no outer managed click remains active. Add a Selenium regression covering this sequence.