Conversation
github-actions
bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the package baseline infrastructure from the ASP.NET Core repository. The baseline system was previously used to ensure packages maintained consistent dependencies across servicing releases, but is no longer needed based on the assumption that this logic is obsolete.
Key Changes:
- Removed the BaselineGenerator tool and all baseline XML files
- Eliminated baseline validation from build targets and scripts
- Updated documentation to remove baseline-related instructions
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/tools/BaselineGenerator/* | Deleted the entire BaselineGenerator tool including Program.cs, .csproj, and README.md |
| eng/Baseline.xml | Deleted the baseline package list for version 9.0.0 |
| eng/Baseline.Designer.props | Deleted the auto-generated baseline properties file (993 lines) |
| eng/targets/ResolveReferences.targets | Removed baseline reference resolution logic, UnusedBaselinePackageReference checks, and BUILD002 error; updated error message to remove baseline mention |
| eng/targets/Packaging.targets | Removed EnsureBaselineIsUpdated target that validated baseline version |
| Directory.Build.targets | Removed Baseline.Designer.props import and baseline version override logic for servicing builds |
| eng/scripts/CodeCheck.ps1 | Removed step that regenerated package baselines |
| eng/Versions.props | Removed ValidateBaseline property |
| eng/Dependencies.props | Removed comment about BaselinePackageReference items |
| src/Components/Components/src/Microsoft.AspNetCore.Components.csproj | Removed SuppressBaselineReference items and related comments |
| AspNetCore.slnx | Removed BaselineGenerator.csproj reference |
| eng/tools/tools.slnf | Removed BaselineGenerator.csproj reference |
| docs/ReferenceResolution.md | Removed baseline-related documentation and examples |
| docs/UpdatingMajorVersionAndTFM.md | Removed instruction to update baselines during major version updates |
| docs/PreparingPatchUpdates.md | Removed instruction to update baselines for patch releases |
adityamandaleeka
approved these changes
Nov 12, 2025
Member
adityamandaleeka
left a comment
adityamandaleeka
left a comment
There was a problem hiding this comment.
LGTM provided that baselining isn't needed anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #61775. Testing the assumption that this logic is no longer used/needed. Will need to check this against a servicing branch to really validate that assumption: #64337