Skip to content

Remove inline JS event handler from NavMenu component in Blazor Web App template #63828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javiercn merged 6 commits into from
Jan 23, 2026
+32 −2
Merged

Remove inline JS event handler from NavMenu component in Blazor Web App template #63828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
91d251b
Initial plan
Copilot Sep 25, 2025
1986110
Remove inline JS event handler from NavMenu component and replace wit…
Copilot Sep 25, 2025
3749489
Add conditional path for NavMenu.razor.js to handle Client project la…
Copilot Dec 19, 2025
e6b5efc
Update template baselines to include NavMenu.razor.js file
Copilot Jan 22, 2026
22c61a6
Fix newline at end of NavMenu.razor.js file
Copilot Jan 22, 2026
24c9f8f
Remove NavMenu.razor.js from blazorwasm template baselines
Copilot Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ojectTemplates/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Components/Layout/NavMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
@inject NavigationManager NavigationManager

##endif*@
@*#if (UseWebAssembly && InteractiveAtRoot) -->
<script type="module" src="@Assets["Layout/NavMenu.razor.js"]"></script>
##else
<script type="module" src="@Assets["Components/Layout/NavMenu.razor.js"]"></script>
##endif*@

<div class="top-row ps-3 navbar navbar-dark">
<div class="container-fluid">
<a class="navbar-brand" href="">BlazorWebCSharp.1</a>
Expand All @@ -12,7 +18,7 @@

<input type="checkbox" title="Navigation menu" class="navbar-toggler" />

<div class="nav-scrollable" onclick="document.querySelector('.navbar-toggler').click()">
<div id="nav-scrollable" class="nav-scrollable">
<nav class="nav flex-column">
<div class="nav-item px-3">
<NavLink class="nav-link" href="" Match="NavLinkMatch.All">
Expand Down
9 changes: 9 additions & 0 deletions ...ctTemplates/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Components/Layout/NavMenu.razor.js
View file
Open in desktop
Copy link
Member

@javiercn javiercn Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the different template configurations to make sure we are only adding this when needed? I imagine it'll be something in .templates.json.

Copy link
Member

@javiercn javiercn Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot confirm this with me.

Copy link
Contributor Author

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the template configurations. The JS file is already correctly handled by the existing template.json:

  1. Exclusion when needed: The wildcard pattern NavMenu.* (line 120) automatically excludes the JS file when !SampleContent (empty template)
  2. Client project handling: The rename configuration (line 67) moves all NavMenu.* files to the Client project when UseWebAssembly && InteractiveAtRoot
  3. Conditional paths: Added conditional script references matching the ReconnectModal pattern to use the correct asset path based on project structure

Tested across all configurations: ✅ Server default, ✅ WebAssembly + global, ✅ None interactivity, ✅ Empty template.

Fixed in commit 3749489.

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Handle navigation menu toggle
const navScrollable = document.getElementById("nav-scrollable");
const navToggler = document.querySelector(".navbar-toggler");

if (navScrollable && navToggler) {
navScrollable.addEventListener("click", function() {
navToggler.click();
});
}
17 changes: 16 additions & 1 deletion src/ProjectTemplates/test/Templates.Tests/template-baselines.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,7 @@
"Components/Layout/MainLayout.razor.css",
"Components/Layout/NavMenu.razor",
"Components/Layout/NavMenu.razor.css",
"Components/Layout/NavMenu.razor.js",
"Components/Pages/Error.razor",
"Components/Pages/Home.razor",
"Components/Pages/NotFound.razor",
Expand Down Expand Up @@ -648,6 +649,7 @@
"Components/Layout/MainLayout.razor.css",
"Components/Layout/NavMenu.razor",
"Components/Layout/NavMenu.razor.css",
"Components/Layout/NavMenu.razor.js",
"Components/Pages/Auth.razor",
"Components/Pages/Error.razor",
"Components/Pages/Home.razor",
Expand Down Expand Up @@ -728,6 +730,7 @@
"Components/Layout/MainLayout.razor.css",
"Components/Layout/NavMenu.razor",
"Components/Layout/NavMenu.razor.css",
"Components/Layout/NavMenu.razor.js",
"Components/Layout/ReconnectModal.razor",
"Components/Layout/ReconnectModal.razor.css",
"Components/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -844,6 +847,7 @@
"Components/Layout/MainLayout.razor.css",
"Components/Layout/NavMenu.razor",
"Components/Layout/NavMenu.razor.css",
"Components/Layout/NavMenu.razor.js",
"Components/Layout/ReconnectModal.razor",
"Components/Layout/ReconnectModal.razor.css",
"Components/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -971,6 +975,7 @@
"Components/Layout/MainLayout.razor.css",
"Components/Layout/NavMenu.razor",
"Components/Layout/NavMenu.razor.css",
"Components/Layout/NavMenu.razor.js",
"Components/Layout/ReconnectModal.razor",
"Components/Layout/ReconnectModal.razor.css",
"Components/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -1055,6 +1060,7 @@
"{ProjectName}/Components/Layout/MainLayout.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor",
"{ProjectName}/Components/Layout/NavMenu.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor.js",
"{ProjectName}/Components/Pages/Error.razor",
"{ProjectName}/Components/Pages/Home.razor",
"{ProjectName}/Components/Pages/NotFound.razor",
Expand Down Expand Up @@ -1180,6 +1186,7 @@
"{ProjectName}/Components/Layout/MainLayout.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor",
"{ProjectName}/Components/Layout/NavMenu.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor.js",
"{ProjectName}/Components/Pages/Error.razor",
"{ProjectName}/Components/Pages/Home.razor",
"{ProjectName}/Components/Pages/NotFound.razor",
Expand Down Expand Up @@ -1260,6 +1267,7 @@
"{ProjectName}/Components/Layout/MainLayout.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor",
"{ProjectName}/Components/Layout/NavMenu.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor.js",
"{ProjectName}/Components/Layout/ReconnectModal.razor",
"{ProjectName}/Components/Layout/ReconnectModal.razor.css",
"{ProjectName}/Components/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -1389,6 +1397,7 @@
"{ProjectName}/Components/Layout/MainLayout.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor",
"{ProjectName}/Components/Layout/NavMenu.razor.css",
"{ProjectName}/Components/Layout/NavMenu.razor.js",
"{ProjectName}/Components/Layout/ReconnectModal.razor",
"{ProjectName}/Components/Layout/ReconnectModal.razor.css",
"{ProjectName}/Components/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -1467,6 +1476,7 @@
"Components/Layout/MainLayout.razor.css",
"Components/Layout/NavMenu.razor",
"Components/Layout/NavMenu.razor.css",
"Components/Layout/NavMenu.razor.js",
"Components/Layout/ReconnectModal.razor",
"Components/Layout/ReconnectModal.razor.css",
"Components/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -1537,6 +1547,7 @@
"{ProjectName}.Client/Layout/MainLayout.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor",
"{ProjectName}.Client/Layout/NavMenu.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor.js",
"{ProjectName}.Client/Pages/Counter.razor",
"{ProjectName}.Client/Pages/Home.razor",
"{ProjectName}.Client/Pages/NotFound.razor",
Expand Down Expand Up @@ -1613,6 +1624,7 @@
"{ProjectName}.Client/Layout/MainLayout.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor",
"{ProjectName}.Client/Layout/NavMenu.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor.js",
"{ProjectName}.Client/Layout/ReconnectModal.razor",
"{ProjectName}.Client/Layout/ReconnectModal.razor.css",
"{ProjectName}.Client/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -1921,6 +1933,7 @@
"Components/Layout/MainLayout.razor.css",
"Components/Layout/NavMenu.razor",
"Components/Layout/NavMenu.razor.css",
"Components/Layout/NavMenu.razor.js",
"Components/Layout/ReconnectModal.razor",
"Components/Layout/ReconnectModal.razor.css",
"Components/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -1998,6 +2011,7 @@
"{ProjectName}.Client/Layout/MainLayout.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor",
"{ProjectName}.Client/Layout/NavMenu.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor.js",
"{ProjectName}.Client/{ProjectName}.Client.csproj",
"{ProjectName}.Client/Pages/Auth.razor",
"{ProjectName}.Client/Pages/Counter.razor",
Expand Down Expand Up @@ -2128,6 +2142,7 @@
"{ProjectName}.Client/Layout/MainLayout.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor",
"{ProjectName}.Client/Layout/NavMenu.razor.css",
"{ProjectName}.Client/Layout/NavMenu.razor.js",
"{ProjectName}.Client/Layout/ReconnectModal.razor",
"{ProjectName}.Client/Layout/ReconnectModal.razor.css",
"{ProjectName}.Client/Layout/ReconnectModal.razor.js",
Expand Down Expand Up @@ -3721,4 +3736,4 @@
]
}
}
}
}
Loading