[release/2.1] Switch to consolidated Windows build images

[dougbu]

No description provided.

[ghost]

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

[ghost]

Hi @dougbu. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[Tratcher]

What else was being thrown?

[dougbu]

From previous build (#20221003.26):

Expected: typeof(System.IO.IOException)
Actual:   typeof(System.ComponentModel.Win32Exception): The client and server cannot communicate, because they do not possess a common algorithm
---- System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm

[dougbu]

/fyi @halter73 @Tratcher the latest Windows images also needed changes in DoesNotSupportTls10() and ClientAttemptingToUseUnsupportedProtocolIsLoggedAsDebug(). #44348 didn't need this because we already compensated for similar changes in release/3.1 as part of #43666

[wtgodbe]

yml parts look good

[dougbu]

Other changed test now working fine. But this one only gets further and fails a few lines down:

Assert.Equal() Failure
Expected: 1
Actual:   2

Stack trace
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.HttpsTests.ClientAttemptingToUseUnsupportedProtocolIsLoggedAsDebug() in /_/src/Servers/Kestrel/test/FunctionalTests/HttpsTests.cs:line 439
--- End of stack trace from previous location where exception was thrown ---

I'm nervous about changing the throwing line to Assert.Equal(2, loggerProvider.FilterLogger.LastEventId); because a similar test in main's src\Servers\Kestrel\test\InMemory.FunctionalTests\HttpsTests.cs uses the current assertions. Thoughts @Tratcher @halter73❔

Will try that change overnight but will await your answers.

[dougbu]

Weird, failed with that change -- Actual: 1 in that case. Removed the extra commit…