Repository navigation
Make SignalR Redis test thread-safe - #41564
Merged
Merged
Conversation
Member
|
It took me a while to find a sample failure. https://dev.azure.com/dnceng/public/_test/analytics?definitionId=278&contextType=build |
halter73
approved these changes
May 21, 2022
Member
Author
Whoops, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestServer could shut down right after the first handler in
is invoked, which creates a race with the second iteration of the loop checking for another item in the list while the list is cleared by the TestServer closing.