Skip to content

Fix h1-4 in identity ui for accessibility #29706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoK merged 39 commits into from
Jan 29, 2021
Merged

Fix h1-4 in identity ui for accessibility #29706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
1385bd6
Accessibility
HaoK Jan 27, 2021
3bf4a09
Accessibility
HaoK Jan 27, 2021
0e07142
Accessibility
HaoK Jan 27, 2021
b1e93f0
Accessibility
HaoK Jan 27, 2021
58bed97
Accessibility
HaoK Jan 27, 2021
a9cf99b
Accessibility
HaoK Jan 27, 2021
d56c0f3
Accessibility
HaoK Jan 27, 2021
3eec2ca
Accessibility
HaoK Jan 27, 2021
5801c0f
Accessibility
HaoK Jan 27, 2021
a63702d
Accessibility
HaoK Jan 27, 2021
3b2b5e5
Accessibility
HaoK Jan 27, 2021
0d4bee0
Accessibility
HaoK Jan 27, 2021
620e95b
Accessibility
HaoK Jan 27, 2021
124f89c
Accessibility
HaoK Jan 27, 2021
29078cb
Accessibility
HaoK Jan 27, 2021
5b5200c
Accessibility
HaoK Jan 27, 2021
b193d74
Accessibility
HaoK Jan 27, 2021
53652ee
Accessibility
HaoK Jan 27, 2021
2cfbc3b
Accessibility
HaoK Jan 27, 2021
a181bbc
Update ExternalLogins.cshtml
HaoK Jan 27, 2021
7b3b777
Accessibility
HaoK Jan 27, 2021
324c19e
Accessibility
HaoK Jan 27, 2021
0b33f45
Update _Layout.cshtml
HaoK Jan 27, 2021
7b5538c
Update Register.cshtml
HaoK Jan 28, 2021
bc397cf
Update Login.cshtml
HaoK Jan 28, 2021
ecee531
Update Index.cshtml
HaoK Jan 28, 2021
a68a1ce
Update Email.cshtml
HaoK Jan 28, 2021
d891a20
Update ChangePassword.cshtml
HaoK Jan 28, 2021
36016e0
Update TwoFactorAuthentication.cshtml
HaoK Jan 28, 2021
c9bcddb
Update ExternalLogins.cshtml
HaoK Jan 28, 2021
f85fc78
Update DeletePersonalData.cshtml
HaoK Jan 28, 2021
684a77c
Update Disable2fa.cshtml
HaoK Jan 28, 2021
94e90c2
Update DownloadPersonalData.cshtml
HaoK Jan 28, 2021
057d291
Update EnableAuthenticator.cshtml
HaoK Jan 28, 2021
85e2440
Update GenerateRecoveryCodes.cshtml
HaoK Jan 28, 2021
862f950
Update PersonalData.cshtml
HaoK Jan 28, 2021
d58ed24
Update ResetAuthenticator.cshtml
HaoK Jan 28, 2021
03f69d1
Update SetPassword.cshtml
HaoK Jan 28, 2021
95663b7
Update ShowRecoveryCodes.cshtml
HaoK Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ConfirmEmailChange.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
ViewData["Title"] = "Confirm email change";
}

<h2>@ViewData["Title"]</h2>
<h1>@ViewData["Title"]</h1>
Copy link
Member

@javiercn javiercn Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaoK this likely changes the visuals, are PMs ok with the new visual aspect?

We can use the h2 and so on Bootstrap classes to keep the visual aspect the same while being correct about the markup.

<partial name="_StatusMessage" model="Model.StatusMessage" />
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ExternalLogin.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
}

<h1>@ViewData["Title"]</h1>
<h4 id="external-login-title">Associate your @Model.ProviderDisplayName account.</h4>
<h2 id="external-login-title">Associate your @Model.ProviderDisplayName account.</h2>
<hr />

<p id="external-login-description" class="text-info">
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ForgotPassword.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
}

<h1>@ViewData["Title"]</h1>
<h4>Enter your email.</h4>
<h2>Enter your email.</h2>
<hr />
<div class="row">
<div class="col-md-4">
Expand Down
4 changes: 2 additions & 2 deletions src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Login.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<div class="col-md-4">
<section>
<form id="account" method="post">
<h4>Use a local account to log in.</h4>
<h2>Use a local account to log in.</h2>
<hr />
<div asp-validation-summary="ModelOnly" class="text-danger"></div>
<div class="form-group">
Expand Down Expand Up @@ -50,7 +50,7 @@
</div>
<div class="col-md-6 col-md-offset-2">
<section>
<h4>Use another service to log in.</h4>
<h3>Use another service to log in.</h3>
<hr />
@{
if ((Model.ExternalLogins?.Count ?? 0) == 0)
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/ChangePassword.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ViewData["ActivePage"] = ManageNavPages.ChangePassword;
}

<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
<partial name="_StatusMessage" for="StatusMessage" />
<div class="row">
<div class="col-md-6">
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/DeletePersonalData.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ViewData["ActivePage"] = ManageNavPages.PersonalData;
}

<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>

<div class="alert alert-warning" role="alert">
<p>
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/Disable2fa.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
}

<partial name="_StatusMessage" for="StatusMessage" />
<h1>@ViewData["Title"]</h1>
<h3>@ViewData["Title"]</h3>

<div class="alert alert-warning" role="alert">
<p>
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/DownloadPersonalData.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ViewData["ActivePage"] = ManageNavPages.PersonalData;
}

<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>

@section Scripts {
<partial name="_ValidationScriptsPartial" />
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/Email.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ViewData["ActivePage"] = ManageNavPages.Email;
}

<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
<partial name="_StatusMessage" for="StatusMessage" />
<div class="row">
<div class="col-md-6">
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/EnableAuthenticator.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
}

<partial name="_StatusMessage" for="StatusMessage" />
<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
<div>
<p>To use an authenticator app go through the following steps:</p>
<ol class="list">
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/ExternalLogins.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<partial name="_StatusMessage" for="StatusMessage" />
@if (Model.CurrentLogins?.Count > 0)
{
<h4>Registered Logins</h4>
<h3>Registered Logins</h3>
<table class="table">
<tbody>
@foreach (var login in Model.CurrentLogins)
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/GenerateRecoveryCodes.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
}

<partial name="_StatusMessage" for="StatusMessage" />
<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
<div class="alert alert-warning" role="alert">
<p>
<span class="glyphicon glyphicon-warning-sign"></span>
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/Index.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ViewData["ActivePage"] = ManageNavPages.Index;
}

<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
<partial name="_StatusMessage" for="StatusMessage" />
<div class="row">
<div class="col-md-6">
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/PersonalData.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ViewData["ActivePage"] = ManageNavPages.PersonalData;
}

<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>

<div class="row">
<div class="col-md-6">
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/ResetAuthenticator.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
}

<partial name="_StatusMessage" for="StatusMessage" />
<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
<div class="alert alert-warning" role="alert">
<p>
<span class="glyphicon glyphicon-warning-sign"></span>
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/SetPassword.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ViewData["ActivePage"] = ManageNavPages.ChangePassword;
}

<h4>Set your password</h4>
<h3>Set your password</h3>
<partial name="_StatusMessage" for="StatusMessage" />
<p class="text-info">
You do not have a local username/password for this site. Add a local
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/ShowRecoveryCodes.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
}

<partial name="_StatusMessage" for="StatusMessage" />
<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
<div class="alert alert-warning" role="alert">
<p>
<strong>Put these codes in a safe place.</strong>
Expand Down
4 changes: 2 additions & 2 deletions src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/TwoFactorAuthentication.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}

<partial name="_StatusMessage" for="StatusMessage" />
<h4>@ViewData["Title"]</h4>
<h3>@ViewData["Title"]</h3>
@{
var consentFeature = HttpContext.Features.Get<ITrackingConsentFeature>();
@if (consentFeature?.CanTrack ?? true)
Expand Down Expand Up @@ -46,7 +46,7 @@
<a asp-page="./GenerateRecoveryCodes" class="btn btn-primary">Reset recovery codes</a>
}

<h5>Authenticator app</h5>
<h4>Authenticator app</h4>
@if (!Model.HasAuthenticator)
{
<a id="enable-authenticator" asp-page="./EnableAuthenticator" class="btn btn-primary">Add authenticator app</a>
Expand Down
4 changes: 2 additions & 2 deletions src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
}
}

<h2>Manage your account</h2>
<h1>Manage your account</h1>

<div>
<h4>Change your account settings</h4>
<h2>Change your account settings</h2>
<hr />
<div class="row">
<div class="col-md-3">
Expand Down
4 changes: 2 additions & 2 deletions src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Register.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div class="row">
<div class="col-md-4">
<form id="registerForm" asp-route-returnUrl="@Model.ReturnUrl" method="post">
<h4>Create a new account.</h4>
<h2>Create a new account.</h2>
<hr />
<div asp-validation-summary="ModelOnly" class="text-danger"></div>
<div class="form-group">
Expand All @@ -32,7 +32,7 @@
</div>
<div class="col-md-6 col-md-offset-2">
<section>
<h4>Use another service to register.</h4>
<h3>Use another service to register.</h3>
<hr />
@{
if ((Model.ExternalLogins?.Count ?? 0) == 0)
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ResendEmailConfirmation.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
}

<h1>@ViewData["Title"]</h1>
<h4>Enter your email.</h4>
<h2>Enter your email.</h2>
<hr />
<div class="row">
<div class="col-md-4">
Expand Down
2 changes: 1 addition & 1 deletion src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ResetPassword.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
}

<h1>@ViewData["Title"]</h1>
<h4>Reset your password.</h4>
<h2>Reset your password.</h2>
<hr />
<div class="row">
<div class="col-md-4">
Expand Down