React to dotnet/runtime SSL changes #18584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It may be worth skipping these tests until we know precisely that either it's expected behavior or a regression. Either way to move with dependency updates, let's merge this. |
jkotalik
approved these changes
Jan 26, 2020
Member
|
File a tracking issue. Throwing a different (and inconsistent) exception is a regression. |
Member
|
I will take a look. This can be also outcome of work for dotnet/runtime#914. The general expectation is that if peer sends encrypted alert we would throw AuthenticationException. If peer closes the connection or if there is an incomplete frame we would throw IOException. In the past, we did not always handle alerts properly e.g. we failed to propagate them from the OS layer. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are getting an
AuthenticationExceptionon Fedora, Debian, and Ubuntu 18 (which run on internal CI only).Is this expected behavior? Do we want to check for either
IOExceptionorAuthenticationException?Likely caused by: dotnet/runtime#453
cc @wfurt