Skip to content

[review-pull-request] CCR overview cards deduplicate distinct anchored worker candidates without verification (#70532) #70674

Open

Agent suggestions

Public preview

Description

@PureWeen

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Part of EPIC #70231.

In .github/skills/review-pull-request/scripts/prepare-review.cs:513-528, 1554-1558 (afdb030a14), ProjectFeedbackAsync projects every entry from pulls/{pr}/reviews into feedback.json's reviews array (required/feedback/reviews/{id}.source), including automated copilot-pull-request-reviewer[bot] <!-- ccr-overview-v2 --> overview cards. .github/skills/review-pull-request/SKILL.md:228-229, 249-255, 365-366 instructs the coordinator to deduplicate candidates covered by an "equivalent earlier issue, review, resolved inline comment, or current feedback" into EXISTING_FEEDBACK_COVERAGE, without distinguishing topical coverage of an unanchored design question from an anchored changed-line candidate that has a different trigger and code mechanism.

Live occurrence: PR #70532 (run 43397825462)

On #70532 (Fix ambiguous Blazor framework endpoints when mapping multiple roots, run 43397825462, frozen head 161ad276cf928913052abb4d23f0a6b5b3fa7014), both routed specialist guide workers (BlazorComponentsGuidance.md and CrossCuttingGuidance.md) independently proposed an anchored P2 candidate at src/Components/Endpoints/src/Builder/BlazorWebEndpointMatcherPolicy.cs:43:

  • Worker candidate: BlazorWebEndpointMatcherPolicy.ApplyAsync deduplicates duplicate framework endpoints across multiple MapRazorComponents roots by comparing candidates[i].Endpoint.RequestDelegate == candidates[j].Endpoint.RequestDelegate (delegate reference equality). When an application registers a delegate-wrapping convention via RazorComponentsEndpointConventionBuilder.Add(b => { var next = b.RequestDelegate!; b.RequestDelegate = ctx => next(ctx); }), RazorComponentEndpointDataSource.AddFrameworkEndpoints produces a distinct RequestDelegate per root, so RequestDelegate == RequestDelegate evaluates false and DefaultEndpointSelector.cs:86-94 still throws AmbiguousMatchException on /_framework/opaque-redirect and the browser-tools settings path.
  • Coordinator bypass of verification via EXISTING_FEEDBACK_COVERAGE: Instead of sending the anchored candidate to review-candidate-verifier, the coordinator skipped verification and returned STATUS: NO_FINDINGS, recording the candidate under EXISTING_FEEDBACK_COVERAGE:

    "Review 5887712198 already covers the source-supported equal-priority framework-endpoint concern involving differing root conventions and missing overlap coverage. Deduplication is neutral and does not endorse that review."

  • Actual content of Review 5887712198 vs. independent verification: Review 5887712198 (copilot-pull-request-reviewer[bot], state COMMENTED) is a top-level <!-- ccr-overview-v2 --> overview card containing **No open issues** 🎉, a changed-file summary table, and ### 🔵 Needs a closer look ("Human review is needed because the tie-breaker selects between equal-priority roots with different conventions or route values, and the supplied tests do not cover those overlaps"), with zero inline comments and no mention of BlazorWebEndpointMatcherPolicy.cs:43 or RequestDelegate wrapper identity. While that attention note legitimately covers a topical equal-priority root-convention question (as linked in #70532 (comment)), conflating it with the RequestDelegate == RequestDelegate wrapper candidate bypassed review-candidate-verifier (which in #70532 comment 6853116119 independently evaluated that candidate as DROP / contradicted / oldVsNew because the ambiguity pre-existed mergeBase). No hosted review on Fix ambiguous Blazor framework endpoints when mapping multiple roots #70532 verified or published that candidate at frozen head 161ad276cf928913052abb4d23f0a6b5b3fa7014 (the PR remains open and has since been reworked to remove request-time tie-breaking).

Describe the solution you'd like

  1. Tighten EXISTING_FEEDBACK_COVERAGE equivalence in SKILL.md (SKILL.md:228-229, 249-255) and mirror into .github/workflows/pull-request-review.md (:958):
    • Require EXISTING_FEEDBACK_COVERAGE for an anchored changed-line candidate to match the same specific changed-line mechanism, trigger, and failure effect — never an unanchored PR walkthrough, file table, or topical <!-- ccr-overview-v2 --> "Needs a closer look" / "No open issues" overview note that discusses a different mechanism.
    • Preserve existing-feedback linking/deduplication when a candidate is at the same topical intent/policy level as an existing "Needs a closer look" note, and preserve SKILL.md:250-253 (from closed [Review agent] Distinguish primary errors from newly suppressed secondary failures (#69445) #70269) retaining unsettled failure-policy concerns in UNRESOLVED with their existing thread reference.
    • Ensure EXISTING_FEEDBACK_COVERAGE never substitutes for review-candidate-verifier when the existing feedback does not establish the same mechanism.
  2. Optionally classify automated overview reviews in prepare-review.cs without dropping them (prepare-review.cs:513-528, 568, 651 + PrepareReviewTests.cs):
    • Keep <!-- ccr-overview-v2 --> entries in feedback.json's reviews array so legitimate topical "Needs a closer look" coverage is preserved, and if adding a projection hint (such as "kind": "automated-overview"), update ValidateProjectedFeedback / RequireProperties (prepare-review.cs:568, 651) and PrepareReviewTests.cs together.
  3. Add two-sided eval regression coverage (eng/skill-evals/review-pull-request/):
    • Case A: a <!-- ccr-overview-v2 --> overview card with "Needs a closer look" + "No open issues" does not suppress a distinct anchored changed-line candidate into EXISTING_FEEDBACK_COVERAGE ahead of verification.
    • Case B: a topical intent/convention question matching a "Needs a closer look" overview item continues to link/deduplicate cleanly rather than reposting duplicate feedback.

Additional context

Activity

  1. github-actions commented on Nov 17, 2026

    @github-actions
    Contributor

    Triage Summary

    Area: area-infrastructure (review-pull-request skill, prepare-review.cs, and skill evals under .github/ and eng/)
    Type: Task (guidance and eval changes to review tooling)

    Potential Duplicates

    • None found

    Notes

    Generated by Issue Triage Agent for dotnet/aspnetcore for #70674 · copilot · auto · 22.3 AIC · ⌖ 1.09 AIC · ⊞ 7.8K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions