Repository navigation
Agent suggestions
Public previewDescription
Is there an existing issue for this?
- I have searched the existing issues
Is your feature request related to a problem? Please describe the problem.
Part of EPIC #70231.
In .github/skills/review-pull-request/scripts/prepare-review.cs:513-528, 1554-1558 (afdb030a14), ProjectFeedbackAsync projects every entry from pulls/{pr}/reviews into feedback.json's reviews array (required/feedback/reviews/{id}.source), including automated copilot-pull-request-reviewer[bot] <!-- ccr-overview-v2 --> overview cards. .github/skills/review-pull-request/SKILL.md:228-229, 249-255, 365-366 instructs the coordinator to deduplicate candidates covered by an "equivalent earlier issue, review, resolved inline comment, or current feedback" into EXISTING_FEEDBACK_COVERAGE, without distinguishing topical coverage of an unanchored design question from an anchored changed-line candidate that has a different trigger and code mechanism.
Live occurrence: PR #70532 (run 43397825462)
On #70532 (Fix ambiguous Blazor framework endpoints when mapping multiple roots, run 43397825462, frozen head 161ad276cf928913052abb4d23f0a6b5b3fa7014), both routed specialist guide workers (BlazorComponentsGuidance.md and CrossCuttingGuidance.md) independently proposed an anchored P2 candidate at src/Components/Endpoints/src/Builder/BlazorWebEndpointMatcherPolicy.cs:43:
- Worker candidate:
BlazorWebEndpointMatcherPolicy.ApplyAsyncdeduplicates duplicate framework endpoints across multipleMapRazorComponentsroots by comparingcandidates[i].Endpoint.RequestDelegate == candidates[j].Endpoint.RequestDelegate(delegate reference equality). When an application registers a delegate-wrapping convention viaRazorComponentsEndpointConventionBuilder.Add(b => { var next = b.RequestDelegate!; b.RequestDelegate = ctx => next(ctx); }),RazorComponentEndpointDataSource.AddFrameworkEndpointsproduces a distinctRequestDelegateper root, soRequestDelegate == RequestDelegateevaluatesfalseandDefaultEndpointSelector.cs:86-94still throwsAmbiguousMatchExceptionon/_framework/opaque-redirectand the browser-tools settings path. - Coordinator bypass of verification via
EXISTING_FEEDBACK_COVERAGE: Instead of sending the anchored candidate toreview-candidate-verifier, the coordinator skipped verification and returnedSTATUS: NO_FINDINGS, recording the candidate underEXISTING_FEEDBACK_COVERAGE:"Review 5887712198 already covers the source-supported equal-priority framework-endpoint concern involving differing root conventions and missing overlap coverage. Deduplication is neutral and does not endorse that review."
- Actual content of Review
5887712198vs. independent verification: Review5887712198(copilot-pull-request-reviewer[bot], stateCOMMENTED) is a top-level<!-- ccr-overview-v2 -->overview card containing**No open issues** 🎉, a changed-file summary table, and### 🔵 Needs a closer look("Human review is needed because the tie-breaker selects between equal-priority roots with different conventions or route values, and the supplied tests do not cover those overlaps"), with zero inline comments and no mention ofBlazorWebEndpointMatcherPolicy.cs:43orRequestDelegatewrapper identity. While that attention note legitimately covers a topical equal-priority root-convention question (as linked in #70532 (comment)), conflating it with theRequestDelegate == RequestDelegatewrapper candidate bypassedreview-candidate-verifier(which in#70532comment6853116119independently evaluated that candidate asDROP/contradicted/oldVsNewbecause the ambiguity pre-existedmergeBase). No hosted review on Fix ambiguous Blazor framework endpoints when mapping multiple roots #70532 verified or published that candidate at frozen head161ad276cf928913052abb4d23f0a6b5b3fa7014(the PR remains open and has since been reworked to remove request-time tie-breaking).
Describe the solution you'd like
- Tighten
EXISTING_FEEDBACK_COVERAGEequivalence inSKILL.md(SKILL.md:228-229, 249-255) and mirror into.github/workflows/pull-request-review.md(:958):- Require
EXISTING_FEEDBACK_COVERAGEfor an anchored changed-line candidate to match the same specific changed-line mechanism, trigger, and failure effect — never an unanchored PR walkthrough, file table, or topical<!-- ccr-overview-v2 -->"Needs a closer look"/"No open issues"overview note that discusses a different mechanism. - Preserve existing-feedback linking/deduplication when a candidate is at the same topical intent/policy level as an existing
"Needs a closer look"note, and preserveSKILL.md:250-253(from closed [Review agent] Distinguish primary errors from newly suppressed secondary failures (#69445) #70269) retaining unsettled failure-policy concerns inUNRESOLVEDwith their existing thread reference. - Ensure
EXISTING_FEEDBACK_COVERAGEnever substitutes forreview-candidate-verifierwhen the existing feedback does not establish the same mechanism.
- Require
- Optionally classify automated overview reviews in
prepare-review.cswithout dropping them (prepare-review.cs:513-528, 568, 651+PrepareReviewTests.cs):- Keep
<!-- ccr-overview-v2 -->entries infeedback.json'sreviewsarray so legitimate topical"Needs a closer look"coverage is preserved, and if adding a projection hint (such as"kind": "automated-overview"), updateValidateProjectedFeedback/RequireProperties(prepare-review.cs:568, 651) andPrepareReviewTests.cstogether.
- Keep
- Add two-sided eval regression coverage (
eng/skill-evals/review-pull-request/):- Case A: a
<!-- ccr-overview-v2 -->overview card with"Needs a closer look"+"No open issues"does not suppress a distinct anchored changed-line candidate intoEXISTING_FEEDBACK_COVERAGEahead of verification. - Case B: a topical intent/convention question matching a
"Needs a closer look"overview item continues to link/deduplicate cleanly rather than reposting duplicate feedback.
- Case A: a
Additional context
- Distinct from closed [Review agent] Distinguish primary errors from newly suppressed secondary failures (#69445) #70269 (preserving unsettled secondary-failure policy concerns alongside existing thread references), [review-pull-request] Pass sibling-worker refutations to review-candidate-verifier and validate remedies against in-repo tests (#70497) #70548 (passing sibling-worker refutations to
review-candidate-verifier), and [Review Agent Failure] Missing review-thread resolution metadata in feedback.json leads to re-litigating resolved threads #70551 (GraphQLreviewThreadsisResolved/isOutdatedmetadata); supersedes the earlier note in #70550 (comment).
Activity
github-actions commentedon Nov 17, 2026
Triage Summary
Area:
area-infrastructure(review-pull-request skill,prepare-review.cs, and skill evals under.github/andeng/)Type:
Task(guidance and eval changes to review tooling)Potential Duplicates
Notes