Repository navigation
Agent suggestions
Public previewDescription
Is there an existing issue for this?
- I have searched the existing issues
Is your feature request related to a problem? Please describe the problem.
Part of EPIC #70231.
Following #70250 (d12d02b143, which added .github/agents/review-candidate-verifier.agent.md) and #70319 (35fbed48c8, which refined its rules), review-candidate-verifier and SKILL.md have exhibited two coupled calibration issues across recent hosted /review runs:
1. Valid findings downgraded to [UNRESOLVED] when in-repo files or standard platform/compiler semantics establish the link
.github/agents/review-candidate-verifier.agent.md:12-20, 24-36 restricts the verifier to the assigned diff, assigned frozen files, and assigned contract artifacts (allowing only an assigned stable BCL contract to establish a link), and :94-98 routes any link depending on an external library, runtime, or transport behavior outside the frozen bundle to DOWNGRADE (downgradeKind: "external", confidence: unresolved). In practice, valid findings have been published as [UNRESOLVED] even when the relevant evidence is in source/<sha> or governed by standard W3C DOM / C# ILLink rules:
- Preserve FocusOnNavigate focus when interactive component replaces prerendered DOM #70308 (run
43078080293,r4541841629onsrc/Components/Web.JS/src/Rendering/FocusOnNavigate.ts:113):- Valid bug fixed by
@dariatiurinaind2783aa062:restoreNavigationFocusused postorderdepthFirstNodeTreeTraversalwhileonAfterRenderCompletedin the same file useddocument.querySelector(selector)?.focus(). Published as[UNRESOLVED]because the verifier treated W3C DOMquerySelectorpreorder semantics and selector contract parity withinFocusOnNavigate.tsas missing from the assigned bundle.
- Valid bug fixed by
- Bound Blazor client validation caching #70453 (run
42926638607,r4532101438onsrc/Components/Endpoints/src/Forms/ClientValidationCache.cs:59):- Valid bug confirmed by
@halter73inr4532399338and5851887134("This looks like a good catch. The NativeAOT publish log reports IL2080 here..."):GetValidatableFieldMetadatacalled unsuppressedfieldKey.ContainerType.GetProperty(...)outsideBuildFieldMetadata's[UnconditionalSuppressMessage("Trimming", "IL2070")]scope (ClientValidationCache.cs:215) whilefieldKey.ContainerType(Type) lacked[DynamicallyAccessedMembers]. Published as[UNRESOLVED]because the verifier stated the bundle had "no target-version linker contract, linker source, or immutable publish artifact proving that this assembly/method is analyzed and that this call emits IL2070", even thoughBuildFieldMetadata(and two helpers at:161, :181) in the same file already carry[UnconditionalSuppressMessage("Trimming", "IL2070")](establishing that the code participates in trimmer/NativeAOT analysis) and C#/ILLink[DynamicallyAccessedMembers]/[UnconditionalSuppressMessage]lexical scoping is a standard compiler/linker rule.
- Valid bug confirmed by
- Fix Blazor Server navigation during circuit startup #70499 (run
43247376089,r4552534794onsrc/Components/Web.JS/src/Platform/Circuits/CircuitManager.ts:544, open PR):NavigationEnhancement.ts:100-108handles same-page#fragmentclicks viahistory.pushStatewithout callingnotifyEnhancedNavigationListeners, leavinglastLocationChangeunset whenCircuitManager.ts:544replays initial URI changes on Server renderer attach. Published as[UNRESOLVED]citing browserhistory.pushStatenot firing navigation events and SignalRISingleClientProxytransport, even thoughhistory.pushStateis standard HTML/DOM behavior and SignalR (src/SignalR/**,src/Components/Server/**) is insource/<sha>.
2. Over-broad external/unestablished classification of in-repo SignalR behavior (#69767) and dropBasis: "unestablished" inline publication (SKILL.md:301-305)
On #69767 (run 43134455604, r4545171667 on src/Components/Server/src/Circuits/RemoteNavigationManager.cs:146 at frozen head 8403c802c0), /review published [P2][UNRESOLVED] Confirm the retained-proxy behavior that produces this timeout, asking to verify from frozen source that target-version SignalR drops messages on ISingleClientProxy while disconnected rather than buffering them — even though src/SignalR/** and src/Components/Server/** are in source/<sha> and the PR includes unit test NavigateTo_WhenInteropCannotComplete_DoesNotRaiseUnhandledException (src/Components/Server/test/Circuits/RemoteNavigationManagerTest.cs:19) and E2E test NavigationIssuedWhileDisconnected_TimesOutWithoutTerminatingReconnectedCircuit (src/Components/test/E2ETest/ServerExecutionTests/NavigationReconnectionTest.cs:35).
Furthermore, .github/skills/review-pull-request/SKILL.md:301-305 currently maps both DOWNGRADE (downgradeKind: "external") and DROP (dropBasis: "unestablished") into NEW_FINDINGS with confidence: unresolved ([UNRESOLVED]). Consequently, even when the verifier rejects an unverified hypothesis with decision: "DROP" (dropBasis: "unestablished"), SKILL.md:301-305 still publishes it as an inline PR comment.
Describe the solution you'd like
- Require in-repo inspection before claiming
external(.github/skills/review-pull-request/SKILL.md:267-292,.github/agents/review-candidate-verifier.agent.md:12-20, 24-36, 94-98):- Require the coordinator's verifier package and the verifier itself to inspect in-repo callers, sibling assemblies (
src/SignalR/**,src/Components/**, template callers), existing in-file/in-assembly trimmer/AOT annotations ([UnconditionalSuppressMessage("Trimming" | "Trimmer", ...)],[DynamicallyAccessedMembers],[RequiresUnreferencedCode],[RequiresDynamicCode]), and project/directory MSBuild properties (.csproj,Directory.Build.props,eng/TrimmableProjects.props) insidesource/<sha>before classifying a first-party dependency or trimmer/AOT contract asexternal.
- Require the coordinator's verifier package and the verifier itself to inspect in-repo callers, sibling assemblies (
- Allow documented, version-invariant platform/language/compiler semantics in
links.trigger/links.effect(review-candidate-verifier.agent.md:31-36, 94-98):- Extend the existing assigned-BCL allowance (
lines 31-34) so standard, version-invariant runtime/platform/compiler contracts — specifically BCL APIs, W3C DOM/HTML specifications (e.g.,document.querySelectorpreorder tree-order matching,history.pushStatenot firingpopstate/navigation events), and C#/ILLink[DynamicallyAccessedMembers]/[UnconditionalSuppressMessage]lexical scoping rules when trimmer/AOT analysis is evidenced by in-file/in-assembly trimmer attributes or project properties — may establishlinks.triggerandlinks.effectwithout requiring an external spec file in the bundle (KEEP->confidence: verified). - Reserve
DOWNGRADE(downgradeKind: "external") for genuine external library/runtime implementation details not present insource/<sha>(such asMessagePackinternal bounds checks on Reduce allocations when parsing SignalR MessagePack messages #70143,org.msgpack.core.MessageUnpackerstate after exceptions on Validate SignalR Java MessagePack binary lengths before allocation #70260,dotnet/runtimegetAssemblyExportsinternals on [blazor] Fix Web Worker initialization on CoreCLR #70504, orMSALerror string formatting on Update azure/msal-browser #66055).
- Extend the existing assigned-BCL allowance (
- Stop publishing
DROP(dropBasis: "unestablished") as inline PR review comments (.github/skills/review-pull-request/SKILL.md:301-305):- Change
SKILL.md:301-305sodecision: "DROP"withdropBasis: "unestablished"is recorded only in the structuredUNRESOLVEDsummary section of the final output and is not kept inNEW_FINDINGSfor inline GitHub PR comment publication. Once [review-pull-request] Stop publishing contradicted [DISCARDED] candidates as inline GitHub PR review comments #70546 also removes[DISCARDED]from inlineNEW_FINDINGS, onlyKEEP(verified),DOWNGRADE(intent->question, orexternal->unresolvedper item 2), and the existing head-side contract safety net atSKILL.md:320-324(confidence: question) enterNEW_FINDINGS(if implemented before [review-pull-request] Stop publishing contradicted [DISCARDED] candidates as inline GitHub PR review comments #70546, leaveDROPwithdropBasis: "contradicted"unchanged for [review-pull-request] Stop publishing contradicted [DISCARDED] candidates as inline GitHub PR review comments #70546). - Update
eng/skill-evals/review-pull-request/catch-policy.vally.yaml:103(logging-policy-unspecified) and align open PR Add review-candidate-verifier Vally suite and evaluation harness #70318'seng/skill-evals/grade_disposition.mjs(case-06) so unestablished-contractDROPs assert presence in structuredUNRESOLVEDwithSTATUS: NO_FINDINGSand!hasCandidate('NEW_FINDINGS').
- Change
- Synchronize embedded workflow verifier instructions:
- Mirror all
.github/agents/review-candidate-verifier.agent.mdupdates in.github/workflows/pull-request-review.md:995-1111and recompile.github/workflows/pull-request-review.lock.yml(enforced by.github/workflows/tests/pull-request-review-adaptive-validation.test.mjs:49-58).
- Mirror all
Additional context
- Related to [review-pull-request] Stop publishing contradicted [DISCARDED] candidates as inline GitHub PR review comments #70546, [Review agent] False positive: MessagePack count validation ignored on #70143 #70232, [Review agent] Distinguish primary errors from newly suppressed secondary failures (#69445) #70269, [Review agent] Pass PR description and linked issue context to review-candidate-verifier to avoid false intent-downgrade questions #70335, Add candidate verifier agent with tiered intent handling to review-pull-request #70250, and Refine review-candidate-verifier rules for external triggers, test gaps, and secondary-failure catches #70319.
Activity
github-actions commentedon Nov 12, 2026
Triage Summary
Area:
area-infrastructure(review-pull-request skill / review-candidate-verifier agent tooling)Type:
Task(bounded calibration of agent behavior)Potential Duplicates
Notes
-; details of the observed verifier behavior, an example PR, and the expected handling are needed to act on it.PureWeen commentedon Nov 13, 2026
Additional live occurrence on 2026-11-13: PR #70562 (run
43375184261)Run
43375184261on #70562 (Add the Screen Orientation API to Microsoft.AspNetCore.Components.Platform, frozen head897ea9d3889cd8c606f41c84f0bd89e75b8c0c1c) published two verifier-dropped (decision: "DROP",dropBasis: "unestablished") candidates as inline[UNRESOLVED]PR review comments:r4560194274(src/Components/Platform/src/ScreenOrientation.cs:111) —**[UNRESOLVED] A late successful orientation acquisition is never disposed**(P2):decision: "DROP",dropBasis: "unestablished", noting: "the assigned base-tip patterns deliberately skip pending acquisitions rather than requiring late-result cleanup.".github/skills/port-components-platform-api/SKILL.md:113-119explicitly mandates this exact behavior: "Release the reference only when the acquisition has already completed successfully. A reference that arrives after disposal is never released. This is accepted. It happens only when the scope ends during an acquisition, and it leaves at most one reference for each family. A circuit that waits a minute to close costs more."r4560194281(src/Components/Platform/testassets/PlatformTestApp.E2E.Tests/Tests/ScreenTests.cs:54) —**[UNRESOLVED] Orientation coverage is outside the prescribed Components Selenium surface**(P3):decision: "DROP",dropBasis: "unestablished", noting missing red/green evidence for a Selenium test..github/skills/port-components-platform-api/SKILL.md:155-158explicitly mandates thatMicrosoft.AspNetCore.Components.PlatformE2E coverage live inPlatformTestAppandPlatformTestApp.E2E.Tests(the package's Playwright E2E suite), whereassrc/Components/AGENTS.md/docs/BlazorComponentsGuidance.mdstates the generalsrc/Components/test/E2ETestSelenium rule without mentioning thesrc/Components/Platform/testassets/PlatformTestApp.E2E.Testsexception.PureWeen commentedon Nov 13, 2026
Additional live occurrence on 2026-11-13: PR #69850 (run
43394407217) — valid in-repo bug unnecessarily downgraded to[UNRESOLVED](downgradeKind: "external")Run
43394407217on #69850 ([Blazor] Preserve modal dialog state during enhanced SSR DOM synchronization, frozen head52f54afd090f74264ed0c02e4d158e36983b203b) found a genuine P2 regression atr4561309455(src/Components/Web.JS/src/Rendering/DomMerging/DomSync.ts:287):**[UNRESOLVED] Open data-permanent dialogs are no longer preserved across cross-page enhanced navigation**— the new!options.preserveModalState && a instanceof HTMLDialogElement && a.matches(':modal')check indomNodeComparerreturnsUpdateCost.Infinitebefore thedata-permanentmatch check (DomSync.ts:325-332), routing matching<dialog data-permanent>elements throughtreatAsDeletion(nodeToDelete.close()) and replacement instead oftreatAsMatch(isDataPermanentElementretention atDomSync.ts:199-206).review-candidate-verifierconfirmed all six repository proof links (changedLine,trigger,oldVsNew,effect,contract,intent), yet still returneddecision: "DOWNGRADE",downgradeKind: "external"with:HTMLDialogElement.showModal()causing<dialog>to match:modalis standard HTML specification behavior and is the exact premise of the PR's own added condition (a instanceof HTMLDialogElement && a.matches(':modal')). Requiring an external browser specification file in the frozen Git bundle to prove standard DOM semantics forces valid browser/JS findings into[UNRESOLVED].(Also note on
#70562: author@jsakamotoIGJPreplied to both[UNRESOLVED]commentsr4560194274andr4560194281confirming both were intentional per.github/skills/port-components-platform-api/SKILL.mdand resolving both threads; see also #70565.)PureWeen commentedon Nov 13, 2026
Updates on 2026-11-13:
#70499(r4552534794) fixed by author + additionaldowngradeKind: "external"occurrence on#70343(r4562634162)r4552534794):[P2][UNRESOLVED]finding from run43247376089(CircuitManager.ts:544, downgraded toexternalonly because browserhistory.pushStateand SignalR transport were outside the frozen bundle) was confirmed and fixed by@karmegams02in commit5633207bdd(r4562990680), which recordsrecordLocationChange(absoluteInternalHref, true)inNavigationEnhancement.ts's hash-only branch and adds E2E coverage.downgradeKind: "external"occurrence on #70343 (run43414973483,r4562634162):e86b5e3f868e574aa8287057750fa6f6d452fbc4,BlazorComponentsGuidanceidentified that changingInputSelect.cs:56toCurrentValueAsString ?? string.Emptyleaves<option selected disabled>Choose...</option>(withoutvalue="") selected during static SSR (StaticHtmlRenderer.HtmlWriting.cs:113-156,307-339), whereas interactive activation reappliesselect.value = ""(BrowserRenderer.ts:303,DomSpecialPropertyUtil.ts:84,135-149) and clears the selection (selectedIndex0→-1, already confirmed interactively inr4560077095).static-ssr-verifierreturneddecision: "DOWNGRADE",downgradeKind: "external"solely because standard HTML<select>parsing andHTMLSelectElement.value = ""DOM semantics are not in the repository source bundle.PureWeen commentedon Nov 17, 2026
Post-#70319 corpus update (
2026-11-17)Even with #70319 merged on
main(.github/agents/review-candidate-verifier.agent.md:32-36), subsequent hosted/reviewruns continue to show both directions of this calibration gap:A. Deterministic in-repo and standard-contract findings still downgraded to
[UNRESOLVED](11of14recent valid findings)43957960954,r4591768935onsrc/Components/JSInterop/src/JSRuntime.cs:199): deterministicRS0016omission of a newprotectedmember fromPublicAPI.Unshipped.txtdowngraded to[UNRESOLVED]; fixed in12d60052c6.44071773402,r4598856762onStaticRouteHandlerModel.Emitter.cs:310): downgraded claiming missing target-version proof thatMicrosoft.Extensions.DependencyInjectionIServiceProviderIsService.IsService(typeof(string[]))returnstrueafterservices.AddSingleton(new[] { "value" }); confirmed valid by the author inr4600361379for a follow-up PR.43973355549): bothr4592931274(BindConverter.cs:688genericnullguard bypassing customTypeConverter) andr4592931293(FormDataMapperTests.cs:448inverted test assertion) downgraded to[UNRESOLVED]; both fixed in8c058d128f.43875900411,r4586400680): E2E test callback-name mismatch downgraded to[UNRESOLVED]; fixed in7a2955b9cf.r4590260911, Shadow-DOMkeydowncomposedPath()retargeting, fixed inbe2fe4be94), Use the declared spacer height for the Virtualize scale factor #70629 (r4591757756, CSSbox-sizingspacer height, fixed in9908afea5b), Release the Virtualize scroll source after an anchor restore #70630 (r4591762934, documentpointerdowntarget filtering, fixed inece344b07a), Fix rendering of HTML enumerated boolean attributes (draggable, spellcheck, contenteditable) #67970 (r4591603724, fixed inede600f4a4), and Make the dotnet-getdocument timeouts configurable #70620 (r4587011709, fixed in2c7623c458).B. Unverified external BCL/SDK assumptions still published inline as
[UNRESOLVED]instead of dropped fromNEW_FINDINGS44113079013,r4601739770onExecutable.cs:74): claimedprocess.Kill()incatchthrowsInvalidOperationExceptionon an already-exited started child process and masksOperationCanceledException. Rejected inr4602240274because modern .NETProcess.Kill()handles already-exited started processes without throwing on Windows (throwIfExited: false) and Unix (ESRCHignored).43957988998,r4591762333onStaticWebAssets.Groups.targets:82): assumed an MSBuild target ran after publish endpoint generation when SDK target ordering runs before endpoint generation (rejected inr4600360906).43937768657,r4590416150onBindConverter.cs:2156): hypothesized BCLUInt32TypeConverterthrowing non-ArgumentExceptionon invalid input when modern .NETBaseNumberConverterthrowsArgumentException(caught by the PR's filter).