Repository navigation
Open
Labels
area-blazorIncludes: Blazor, Razor ComponentsIncludes: Blazor, Razor Componentsarea-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Milestone
Description
Is there an existing issue for this?
- I have searched the existing issues
Is your feature request related to a problem? Please describe the problem.
Across two Microsoft.AspNetCore.Components.Platform PRs (#69970 and #70340), review passes produced P2 lifecycle findings around IJSObjectReference disposal during Blazor DI scope teardown (IInternalAsyncDisposal.InternalDisposeAsync) without establishing a reachable production trigger or accounting for existing repository conventions:
-
Non-waiting pending acquisition at DI scope disposal (
#69970Screen.cs:103and#70340Window.cs:88):- In
Screen.cs(Add Screen to Microsoft.AspNetCore.Components.Platform #69970) andWindow.cs(Add event listeners to Microsoft.AspNetCore.Components.Platform #70340),GetReferenceAsync()caches_jsRuntime.GetValueAsync<IJSObjectReference>(...).AsTask(), andInternalDisposeAsync()intentionally only disposes_referenceTask.Resultwhen_referenceTask is { IsCompletedSuccessfully: true }with the comment:// Don't wait for a pending acquisition. It could hold up scope disposal until the JS interop timeout. if (_referenceTask is { IsCompletedSuccessfully: true } referenceTask) { await referenceTask.Result.DisposeAsync().ConfigureAwait(false); }
- Review arms (a review model and a review model on Add Screen to Microsoft.AspNetCore.Components.Platform #69970; a review model on Add event listeners to Microsoft.AspNetCore.Components.Platform #70340) flagged a
P2leak if the scope is disposed whileGetReferenceAsync()is still in flight and the JS reference arrives afterward. - While the source-level mechanism is conditionally possible if an
IJSRuntimecompletesGetValueAsyncafterInternalDisposeAsyncchecks_referenceTask.IsCompletedSuccessfully(andJSCallbackFactory.ImportModuleAsyncin Add event listeners to Microsoft.AspNetCore.Components.Platform #70340 explicitly disposes a late-arriving module to satisfyBrowserJSRuntimeunit tests that callServiceProvider.DisposeAsync()while holding"import"), this exact non-waiting pattern is already established inStorage.cs:111-115andCookieStore.cs:179-183onmain. - Furthermore,
Window.AddEventListenerAsyncalready throwsObjectDisposedExceptionafterawait GetReferenceAsync()(Window.cs:70), and as the author explained in #69970 comment4489650667, Blazor DI scope disposal in supported hosts runs during Interactive Server circuit teardown (where inbound interop completion and disposal are serialized on the circuit/renderer dispatcher) or WebAssembly page unload — so aP2production leak claim is not established without a concrete supported-host trigger.
- In
-
Exception propagation during
IJSObjectReference.DisposeAsyncat DI scope disposal (#70340Window.cs:159, CCR comment4489112121):- Separately from the pending-acquisition pattern above, CCR comment
4489112121(and corroborating review notes) claimed thatawait referenceTask.Result.DisposeAsync()inWindow.InternalDisposeAsync()could throwJSDisconnectedExceptionorTaskCanceledExceptionduring circuit teardown and skip subsequent feature cleanup. - As the author noted in #70340 comment
4489969683,CircuitHost.DisposeAsynccallsJSRuntime.MarkPermanentlyDisconnected()before disposing the DI scope (preventing new outbound calls from being sent), andJSObjectReference.DisposeAsyncalready suppressesJSDisconnectedException(since Suppress JSDisconnectedException in IJSObjectReference.DisposeAsync #64773).
- Separately from the pending-acquisition pattern above, CCR comment
Describe the solution you'd like
- Calibrate Blazor Components / JSInterop review guidance (
docs/BlazorComponentsGuidance.mdand/or.github/agents/review-candidate-verifier.agent.md):- Document the Blazor DI scope teardown contract for scoped JS interop projections (
Window,Screen,Storage,CookieStore):- In Interactive Server,
CircuitHostmarksJSRuntimepermanently disconnected before scope disposal runs, inbound completions are coordinated through the circuit/renderer dispatcher, andJSObjectReference.DisposeAsyncalready ignoresJSDisconnectedException. - In WebAssembly, the DI scope for browser platform services lives until page unload.
- Non-waiting disposal of a lazy
Task<IJSObjectReference>(if (_referenceTask is { IsCompletedSuccessfully: true })) that matches existingStorage/CookieStoreconventions is intentional so scope disposal cannot hang on a pending JS interop call, and should not be elevated as aP2blocking production leak unless a reachable non-teardown disposal path is established in the PR.
- In Interactive Server,
- Document the Blazor DI scope teardown contract for scoped JS interop projections (
- Require
review-candidate-verifierto check existing sibling conventions andJSObjectReference.DisposeAsyncexception contracts:- Before keeping a
P2disposal-leak orJSDisconnectedExceptionpropagation candidate on anIJSObjectReference, verify whetherJSObjectReference.DisposeAsyncalready suppresses the claimed exception and whether the disposal path is reachable in a supported host outside circuit/page teardown.
- Before keeping a
Additional context
- Tracked under Review Agent Failure Tracking #70231.
- Evidence PRs:
- Add Screen to Microsoft.AspNetCore.Components.Platform #69970 (
src/Components/Platform/src/Screen.cs:103, author explanation in4489650667) - Add event listeners to Microsoft.AspNetCore.Components.Platform #70340 (
src/Components/Platform/src/Window.cs:88andWindow.cs:159, author explanation in4489969683)
- Add Screen to Microsoft.AspNetCore.Components.Platform #69970 (
Metadata
Metadata
Assignees
Labels
area-blazorIncludes: Blazor, Razor ComponentsIncludes: Blazor, Razor Componentsarea-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Activity
github-actions commentedon Nov 6, 2026
Triage Summary
Area:
area-blazor(Blazor DI scope teardown,IJSObjectReference,Microsoft.AspNetCore.Components.Platform)Type:
Task(preserved)Potential Duplicates
Notes