Microsoft.AspNetCore.Mvc.Testing is broken in SDK 6.0.201

[philip-reed]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

ObjectDisposedException thrown when trying to use the WebApplicationClient targeting SDK 6.0.201.
When reverting to SDK 6.0.200, the issue goes away.

Expected Behavior

ObjectDisposedException should not be thrown.

Steps To Reproduce

Write any test that calls WebApplicationFactory.CreateClient()

Exceptions (if any)

 System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'ConfigurationManager'.
   at Microsoft.Extensions.Configuration.ReferenceCountedProviderManager.AddProvider(IConfigurationProvider provider)
   at Microsoft.Extensions.Configuration.ConfigurationManager.AddSource(IConfigurationSource source)
   at Microsoft.Extensions.Configuration.ConfigurationManager.Microsoft.Extensions.Configuration.IConfigurationBuilder.Add(IConfigurationSource source)
   at Microsoft.AspNetCore.Builder.WebApplicationBuilder.<>c__DisplayClass25_0.<Build>b__2(HostBuilderContext context, IServiceCollection services)
   at Microsoft.Extensions.Hosting.HostBuilder.CreateServiceProvider()
   at Microsoft.Extensions.Hosting.HostBuilder.Build()
   at Microsoft.AspNetCore.Builder.WebApplicationBuilder.Build()
   at Program.<Main>$(String[] args) in D:\GIT\Whds.Packing.App\src\Whds.Packing.StateMachine\Program.cs:line 53

.NET Version

6.0.201

Anything else?

No response

[philip-reed]

dotnet/core#7259

[martincostello]

This might have been introduced by dotnet/runtime#63816.

[martincostello]

FWIW, a more detailed repro might be needed to narrow down what's different in your app that causes this. I use Microsoft.AspNetCore.Mvc.Testing extensively and didn't observe any issues with it when validating the fix or ingesting it yesterday with the 6.0.3 update.

[philip-reed]

Fair enough. I'll see what I can do.

[philip-reed]

Repro here.
Looks like an issue with Convey.

Removing builder.Services.AddConvey(); from Program.cs lets the test pass.

https://github.com/philip-reed/40614

[mumby0168]

Repro here. Looks like an issue with Convey.

https://github.com/philip-reed/40614

Hi looking at Convey it takes a framework reference see here

https://github.com/snatch-dev/Convey/blob/eed6999d518c2bdc7014380d232ef75a000bc4c0/src/Convey/src/Convey/Convey.csproj#L20

Does that framework reference take on the .NET version it was built with?

Still not sure that this would break between minor version tho would it 🤔

[martincostello]

Does that framework reference take on the .NET version it was built with?

I believe it'll take a reference on whichever version of the shared framework for that major version at runtime. There's nothing specific shown in the dependencies tab for Microsoft.AspNetCore.App.

[mumby0168]

Does that framework reference take on the .NET version it was built with?

I believe it'll take a reference on whichever version of the shared framework for that major version at runtime. There's nothing specific shown in the dependencies tab for Microsoft.AspNetCore.App.

Does it look like it's anything to do with Configuration something special Convey is doing maybe?

[martincostello]

There's nothing in particular I can see from a quick glance at the code that's doing much with IConfiguration other than this, I'm not familiar with Convey though.

[mumby0168]

I've spotted a dependency convey takes on Scrutor which is quite old looking at this ->

https://www.nuget.org/packages/Scrutor/3.3.0

[mumby0168]

I've asked the creators on Convey to see if they can add anything to this chat. Does seem odd that it would break given it's only a minor version bump 🤔

[martincostello]

You can see in the issue I linked to that there was quite a large refactor done under the hood in 6.0.3 to fix a deadlock.

[mumby0168]

FYI this also fails when running the project not under the Mvc.Testing package. i.e just a dotnet run