[release/13.0] Fix Azure roles resources always redeploying #12903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
captainsafia and
eerhardt
as code owners
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12903Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12903" |
Everytime we check if we need to redeploy an Azure "roles" resource in run mode, we are getting a different CheckSum. This is because we are overwriting the "known parameters" like PrincipalId and PrincipalType with 'null' values, because these values aren't available yet. The fix is to skip setting those known parameters, like we did in previous versions. Fix #12651
github-actions
bot
force-pushed
the
backport/pr-12901-to-release/13.0
branch
from
4088ae3 to
8480d9d
Compare
davidfowl
approved these changes
Nov 12, 2025
Member
|
@eerhardt who sets skipKnownValues to true? |
Member
The only place it gets set to The other caller is in |
eerhardt
approved these changes
Nov 12, 2025
joperezr
added
Servicing-approved
This was referenced Nov 26, 2025
Merged
This was referenced Dec 17, 2025
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12901 to release/13.0
/cc @eerhardt
Customer Impact
When someone has Azure resources in their app, the "roles" resource is getting redeployed each time the app is run locally. This slows down the dev's inner loop.
Testing
Manually tested the roles resource is cached correctly. Also added a new unit test for the scenario.
Risk
Low. The fix is bringing parts of code that shipped earlier in Aspire 9.5.
Regression?
Yes