Update deployment-docker test scenario to use aspire deploy command
#12468
Conversation
…cker Compose Co-authored-by: captainsafia <[email protected]>
aspire deploy command
There was a problem hiding this comment.
Pull Request Overview
This PR updates the deployment-docker test scenario to use aspire deploy instead of docker compose up for deploying applications. The change simplifies the deployment workflow by using Aspire's built-in deployment command rather than manually invoking Docker Compose, which better represents the intended Aspire deployment experience.
Key changes:
- Replaced
docker compose upworkflow withaspire deploycommand - Simplified deployment verification and cleanup steps
- Updated success criteria and troubleshooting sections to reflect the new deployment method
Comments suppressed due to low confidence (1)
tests/agent-scenarios/deployment-docker/prompt.md:1
- The README.md still describes this scenario as 'deploying it using Docker Compose' and lists features like 'Deploys the application with
docker compose up'. This documentation should be updated to reflect the newaspire deployapproach to stay consistent with the changes made to the prompt.md file.
# Deployment Docker Scenario
| docker ps -a | grep AspireDockerTest | ||
| docker stop $(docker ps -q --filter "name=AspireDockerTest") | ||
| docker rm $(docker ps -aq --filter "name=AspireDockerTest") |
There was a problem hiding this comment.
The cleanup script uses a hardcoded filter 'AspireDockerTest' which may not match the actual container names created by aspire deploy. The scenario should either specify what the expected container naming pattern is, or provide guidance on how to identify the correct containers to clean up. Consider documenting the expected container naming convention or providing a more generic cleanup approach.
|
|
||
| ```bash | ||
| docker compose ps -a | ||
| docker ps -a | grep AspireDockerTest |
There was a problem hiding this comment.
The verification step uses the same hardcoded 'AspireDockerTest' filter. This should match the actual container names that will be created, or the instructions should clarify what pattern to search for based on the actual deployment.
|
/ba-g markdown scenario |
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12468Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12468" |
…#12468) * Initial plan * Update deployment-docker prompt.md to use aspire deploy instead of Docker Compose Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]>
The deployment-docker test scenario was using manual
docker compose upcommands instead of theaspire deploycommand. This updates the scenario to use the proper Aspire deployment workflow.Changes
Step 6: Replaced "Deploy with Docker Compose" section with "Deploy with Aspire Deploy"
docker compose up -dtoaspire deploy -o docker-compose-outputdocker psOverview: Updated test validation points to reflect
aspire deployas the deployment methodSuccess Criteria: Changed deployment success condition from "docker compose up successfully deploys" to "aspire deploy successfully deploys"
Cleanup Steps: Updated to reference the
aspire deploydeployment method in cleanup instructionsChecklist & Troubleshooting: Removed references to
docker compose up/ps/logscommands and endpoint accessibility testingResult
The scenario now follows the correct Aspire deployment workflow using
aspire deployinstead of manual Docker Compose commands, reducing the test from 9 to 8 steps while maintaining deployment validation.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.