-
Notifications
You must be signed in to change notification settings - Fork 747
Fix LoadDeploymentState to check Pipeline:ClearCache instead of Publishing:ClearCache #12452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: captainsafia <[email protected]>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12452Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12452" |
1 similar comment
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12452Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12452" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where the --clear-cache command-line flag was being ignored during deployment state loading. The LoadDeploymentState method was checking the wrong configuration key (Publishing:ClearCache) instead of the correct key (Pipeline:ClearCache), which is where the --clear-cache flag actually maps to in the configuration system.
Key Changes
- Updated
LoadDeploymentState()to checkPipeline:ClearCacheconfiguration key instead ofPublishing:ClearCache
…shing:ClearCache (#12452) * Initial plan * Fix clear cache handling to use Pipeline:ClearCache configuration key Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]>
The
LoadDeploymentStatemethod was checking the wrong configuration key, causing the--clear-cacheflag to be ignored during deployment state loading.Changes
DistributedApplicationBuilder.LoadDeploymentState()to read fromPipeline:ClearCacheinstead ofPublishing:ClearCacheContext
The
--clear-cachecommand-line switch maps toPipeline:ClearCachein the configuration system. The rest of the codebase (FileDeploymentStateManager, PipelineOptions, tests) already usesPipeline:ClearCache, but LoadDeploymentState was checking a non-existentPublishing:ClearCachekey, causing it to always return false and load cached state even when--clear-cachewas specified.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms/usr/local/bin/bicep build /tmp/aspirebEQr20/teststorage.module.bicep --stdout(dns block)/usr/local/bin/bicep build /tmp/aspireHAKv39/teststorage.module.bicep --stdout(dns block)/usr/local/bin/bicep build /tmp/aspirehKoUIN/env.module.bicep --stdout(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.