Remove [ActiveIssue] attributes for resolved issue #11728 from AzureDeployerTests #12396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Co-authored-by: radical <[email protected]>
Copilot
AI
changed the title
[WIP] Remove ActiveIssue attribute for tests referencing issue 11728
Remove [ActiveIssue] attributes for resolved issue #11728 from AzureDeployerTests
Oct 27, 2025
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12396Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12396" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes [ActiveIssue] attributes from 7 test methods in AzureDeployerTests after issue #11728 was resolved. The tests were previously being skipped and will now run as part of the regular test suite.
Key changes:
- Removed
[ActiveIssue("https://github.com/dotnet/aspire/issues/11728")]attribute from 7 test methods - No code logic changes, only test attribute removal
eerhardt
approved these changes
Oct 27, 2025
radical
added a commit
that referenced
this pull request
Oct 29, 2025
…eployerTests (#12396) * Initial plan * Remove [ActiveIssue] attributes for resolved issue #11728 Co-authored-by: radical <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: radical <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11728 has been resolved. The affected tests in
AzureDeployerTestscan now run without being skipped.Changes
[ActiveIssue("https://github.com/dotnet/aspire/issues/11728")]from 7 test methods inAspire.Hosting.Azure.Tests.AzureDeployerTests:DeployAsync_WithContainer_WorksDeployAsync_WithDockerfile_WorksDeployAsync_WithProjectResource_WorksDeployAsync_WithMultipleComputeEnvironments_WorksDeployAsync_WithSingleRedisCache_CallsDeployingComputeResourcesDeployAsync_WithOnlyAzureResources_PrintsDashboardUrlDeployAsync_WithAzureFunctionsProject_WorksThese tests will now execute as part of the regular test suite.
Closes #11728 .
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms/usr/local/bin/bicep build /tmp/aspireluQL9t/env.module.bicep --stdout(dns block)/usr/local/bin/bicep build /tmp/aspire40U1bV/api.module.bicep --stdout(dns block)/usr/local/bin/bicep build /tmp/aspirekc6BCP/env.module.bicep --stdout(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.